Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider having a single HTTP client with fetch #23

Closed
acelaya opened this issue Oct 1, 2023 · 1 comment · Fixed by #242
Closed

Consider having a single HTTP client with fetch #23

acelaya opened this issue Oct 1, 2023 · 1 comment · Fixed by #242
Labels
enhancement
Milestone
2.0.0

Comments

@acelaya
Copy link
Member

acelaya commented Oct 1, 2023

Currently there's two HTTP clients for node and the browser.

However, all node supported versions have fetch, so it should be in theory possible to have a single HTTP client.
@acelaya acelaya added this to the 1.0.0 milestone Oct 1, 2023
@acelaya acelaya added this to Shlink Oct 1, 2023
@acelaya acelaya changed the title Consider having s single HTTP client with fetch Consider having a single HTTP client with fetch Oct 1, 2023
@acelaya acelaya removed this from the 1.0.0 milestone Mar 5, 2024
@acelaya acelaya added this to the 2.0.0 milestone Feb 9, 2025
@acelaya acelaya moved this to In Progress in Shlink Feb 9, 2025
@acelaya acelaya mentioned this issue Feb 9, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Shlink Feb 9, 2025
@acelaya
Copy link
Member Author

acelaya commented Feb 9, 2025

On top of this, Bun and Deno also have fetch, which would allow to support them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Shlink
Status: Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Feature/global fetch acelaya-forks/shlink-js-sdk
1 participant
@acelaya