Skip to content

Commit 9d949c7

Browse files
shingtshingt
committed
Small cleanup
1 parent 69e799c commit 9d949c7

File tree

5 files changed

+27
-32
lines changed

5 files changed

+27
-32
lines changed

‎GitHub-GraphQL-API-Example-iOS.xcodeproj/project.pbxproj

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
isa = PBXProject;
119119
attributes = {
120120
LastSwiftUpdateCheck = 0810;
121-
LastUpgradeCheck = 0810;
121+
LastUpgradeCheck = 1150;
122122
ORGANIZATIONNAME = shingt;
123123
TargetAttributes = {
124124
1201036F1DFBE26E00E8128E = {
@@ -130,10 +130,9 @@
130130
};
131131
buildConfigurationList = 1201036B1DFBE26E00E8128E /* Build configuration list for PBXProject "GitHub-GraphQL-API-Example-iOS" */;
132132
compatibilityVersion = "Xcode 3.2";
133-
developmentRegion = English;
133+
developmentRegion = en;
134134
hasScannedForEncodings = 0;
135135
knownRegions = (
136-
English,
137136
en,
138137
Base,
139138
);
@@ -226,20 +225,30 @@
226225
isa = XCBuildConfiguration;
227226
buildSettings = {
228227
ALWAYS_SEARCH_USER_PATHS = NO;
228+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
229229
CLANG_ANALYZER_NONNULL = YES;
230230
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
231231
CLANG_CXX_LIBRARY = "libc++";
232232
CLANG_ENABLE_MODULES = YES;
233233
CLANG_ENABLE_OBJC_ARC = YES;
234+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
234235
CLANG_WARN_BOOL_CONVERSION = YES;
236+
CLANG_WARN_COMMA = YES;
235237
CLANG_WARN_CONSTANT_CONVERSION = YES;
238+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
236239
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
237240
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
238241
CLANG_WARN_EMPTY_BODY = YES;
239242
CLANG_WARN_ENUM_CONVERSION = YES;
240243
CLANG_WARN_INFINITE_RECURSION = YES;
241244
CLANG_WARN_INT_CONVERSION = YES;
245+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
246+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
247+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
242248
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
249+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
250+
CLANG_WARN_STRICT_PROTOTYPES = YES;
251+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
243252
CLANG_WARN_SUSPICIOUS_MOVES = YES;
244253
CLANG_WARN_UNREACHABLE_CODE = YES;
245254
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -277,20 +286,30 @@
277286
isa = XCBuildConfiguration;
278287
buildSettings = {
279288
ALWAYS_SEARCH_USER_PATHS = NO;
289+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
280290
CLANG_ANALYZER_NONNULL = YES;
281291
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
282292
CLANG_CXX_LIBRARY = "libc++";
283293
CLANG_ENABLE_MODULES = YES;
284294
CLANG_ENABLE_OBJC_ARC = YES;
295+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
285296
CLANG_WARN_BOOL_CONVERSION = YES;
297+
CLANG_WARN_COMMA = YES;
286298
CLANG_WARN_CONSTANT_CONVERSION = YES;
299+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
287300
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
288301
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
289302
CLANG_WARN_EMPTY_BODY = YES;
290303
CLANG_WARN_ENUM_CONVERSION = YES;
291304
CLANG_WARN_INFINITE_RECURSION = YES;
292305
CLANG_WARN_INT_CONVERSION = YES;
306+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
307+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
308+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
293309
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
310+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
311+
CLANG_WARN_STRICT_PROTOTYPES = YES;
312+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
294313
CLANG_WARN_SUSPICIOUS_MOVES = YES;
295314
CLANG_WARN_UNREACHABLE_CODE = YES;
296315
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

‎GitHub-GraphQL-API-Example-iOS.xcodeproj/project.xcworkspace/contents.xcworkspacedata

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎GitHub-GraphQL-API-Example-iOS/AppDelegate.swift

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,11 @@
11
import UIKit
22

33
@UIApplicationMain
4-
class AppDelegate: UIResponder, UIApplicationDelegate {
4+
final class AppDelegate: UIResponder, UIApplicationDelegate {
55

66
var window: UIWindow?
77

88
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
99
return true
1010
}
11-
12-
func applicationWillResignActive(_ application: UIApplication) {
13-
}
14-
15-
func applicationDidEnterBackground(_ application: UIApplication) {
16-
}
17-
18-
func applicationWillEnterForeground(_ application: UIApplication) {
19-
}
20-
21-
func applicationDidBecomeActive(_ application: UIApplication) {
22-
}
23-
24-
func applicationWillTerminate(_ application: UIApplication) {
25-
}
26-
2711
}

‎GitHub-GraphQL-API-Example-iOS/RepositoriesViewController.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ final class RepositoriesViewController: UITableViewController {
1717
return ApolloClient(networkTransport: transport)
1818
}()
1919

20-
override func viewDidLoad() {
21-
super.viewDidLoad()
22-
}
23-
2420
override func viewWillAppear(_ animated: Bool) {
2521
super.viewWillAppear(animated)
2622

‎GitHub-GraphQL-API-Example-iOS/RepositoryCell.swift

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
import UIKit
22

33
final class RepositoryCell: UITableViewCell {
4-
@IBOutlet weak var nameLabel: UILabel!
5-
@IBOutlet weak var urlLabel: UILabel!
6-
@IBOutlet weak var stargazersCountLabel: UILabel!
7-
8-
override func awakeFromNib() {
9-
super.awakeFromNib()
10-
}
4+
@IBOutlet private weak var nameLabel: UILabel!
5+
@IBOutlet private weak var urlLabel: UILabel!
6+
@IBOutlet private weak var stargazersCountLabel: UILabel!
117

128
func configure(with repository: RepositoryDetails) {
139
nameLabel.text = "\(repository.owner.resourcePath)/\(repository.name)"

0 commit comments

Comments
 (0)