From fdcd8e46b2ff02fe4346e822fd9aaaba286a5b8a Mon Sep 17 00:00:00 2001 From: Hardik Sharma Date: Wed, 13 Jul 2022 11:40:57 +0530 Subject: [PATCH] Changed port to 3010, removed console.logs --- packages/announcements/craco.config.js | 2 +- packages/announcements/src/App.js | 1 - packages/announcements/src/pages/Announcements.js | 4 ---- packages/common-lib/src/components/AppShell.tsx | 2 -- .../common-lib/src/components/layout/PinnedAnnouncements.tsx | 1 - 5 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/announcements/craco.config.js b/packages/announcements/craco.config.js index c42fda1f..71fee3a9 100644 --- a/packages/announcements/craco.config.js +++ b/packages/announcements/craco.config.js @@ -3,7 +3,7 @@ const ExternalTemplateRemotesPlugin = require("external-remotes-plugin"); module.exports = { devServer: { - port: 4002, + port: 3010, }, webpack: { plugins: [new ExternalTemplateRemotesPlugin()], diff --git a/packages/announcements/src/App.js b/packages/announcements/src/App.js index e06318dc..9cc4e59c 100644 --- a/packages/announcements/src/App.js +++ b/packages/announcements/src/App.js @@ -30,7 +30,6 @@ function App() { routes={routes} AuthComponent={LoginComponent} isShowPinnedAnnouncements={true} - isShowFooterLink={true} /> ); } diff --git a/packages/announcements/src/pages/Announcements.js b/packages/announcements/src/pages/Announcements.js index 7df165b4..cfb25618 100644 --- a/packages/announcements/src/pages/Announcements.js +++ b/packages/announcements/src/pages/Announcements.js @@ -135,7 +135,6 @@ const Announcements = ({ footerLinks, appName, pinnedAnnouncementsData }) => { setFilterData(f); } }; - console.log(pinnedAnnouncementsData); return ( { ...selectedAnnouncement, ...announcement, })); - console.log(selectedAnnouncement); }} showMoreAnnouncements={showMoreAnnouncements} /> @@ -322,7 +320,6 @@ const Announcements = ({ footerLinks, appName, pinnedAnnouncementsData }) => { } onChange={(e) => { modifyFilter(showFilterModal, value, e); - console.log(e); }} > {value} @@ -335,7 +332,6 @@ const Announcements = ({ footerLinks, appName, pinnedAnnouncementsData }) => { _text={{ color: "white" }} onPress={(e) => { setShowFilterModal(-1); - console.log(filterData); }} > {t("CONTINUE")} diff --git a/packages/common-lib/src/components/AppShell.tsx b/packages/common-lib/src/components/AppShell.tsx index 357cac93..e06072ec 100644 --- a/packages/common-lib/src/components/AppShell.tsx +++ b/packages/common-lib/src/components/AppShell.tsx @@ -59,7 +59,6 @@ function AppShell({ //TODO: integrate with API call to fetch pinned announcements //pinned announcements data is common to all components depending on their - console.log(isShowPinnedAnnouncements, isShowFooterLink) const pinnedAnnouncementsData = !isShowPinnedAnnouncements ? [] : [ @@ -74,7 +73,6 @@ function AppShell({ isDismissable: false } ] - console.log(pinnedAnnouncementsData) useEffect(() => { const subscription = eventBus.subscribe('AUTH', (data, envelop) => { if ((data.eventType = 'LOGIN_SUCCESS')) { diff --git a/packages/common-lib/src/components/layout/PinnedAnnouncements.tsx b/packages/common-lib/src/components/layout/PinnedAnnouncements.tsx index bb7b076b..37793645 100644 --- a/packages/common-lib/src/components/layout/PinnedAnnouncements.tsx +++ b/packages/common-lib/src/components/layout/PinnedAnnouncements.tsx @@ -11,7 +11,6 @@ export default function PinnedAnnouncements({ _pinnedAnnouncementsData }: any) { () => pinnedAnnouncementsList, [pinnedAnnouncementsList] ) - console.log(_pinnedAnnouncementsData) return (