Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no images are displayed #5

Closed
uliw opened this issue Oct 23, 2022 · 6 comments
Closed

no images are displayed #5

uliw opened this issue Oct 23, 2022 · 6 comments

Comments

@uliw
Copy link

uliw commented Oct 23, 2022

[[./graphs/co2_vs_t.pdf]]

and ctrl-c ctrl-x ctrl-v result in no visible change. Neither are any svg files produced

@shg
Copy link
Owner

shg commented Oct 24, 2022

Hello. Below are the few things you may want to check.

  • Does your Emacs show the inline images in other formats like PNG or SVG?
  • Does pdf2svg command work and exist in a path that Emacs knows?
  • Is org-inline-pdf-mode ON in the buffer? What happens if you manually do M-x org-inline-pdf-mode?

@uliw
Copy link
Author

uliw commented Oct 24, 2022

Update 2: all previous errors were caused by a botched startup file. Using vanilla 28.2

  • png shows as expected
  • svg shows as expected
  • pdf show as expected
  • pdf2svg works as expected

It appears that scimax modifies some of the org-image code in such a way that svg generation breaks

@uliw uliw closed this as completed Oct 24, 2022
@shg
Copy link
Owner

shg commented Oct 24, 2022

@uliw Thank you for the info.

I confirmed the conflict with scimax. It seems scimax completely replaces org-display-inline-images with its own function and thus org-inline-pdf's function is not called when scimax is loaded. This might be solved by changing the way org-inline-pdf adds its advice but I haven't tested it yet.

So my understanding is for now you can make org-inline-pdf work by doing M-x scimax-toggle-image-advice correct? I haven't used scimax and I don't know what scimax features it would disable though.

@uliw
Copy link
Author

uliw commented Oct 25, 2022

yes, correct. Toggling climax-toggle-image-advice allows the inlining of pdfs. I'll chat with the author of scimax (a collection of tools for scientific writing)

@shg
Copy link
Owner

shg commented Oct 26, 2022

@uliw Thank you, I will mention the conflict with scimax in the README for now.

@uliw
Copy link
Author

uliw commented Oct 26, 2022

scimax-toggle-image-advice is a rarely used function, so save to have this default to nil in order to be compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants