Skip to content

Commit 4a1b04c

Browse files
committed
Not supporting 1.6 anymore or py2.6
1 parent a1d2426 commit 4a1b04c

File tree

8 files changed

+17
-37
lines changed

8 files changed

+17
-37
lines changed

pinax/notifications/compat.py

-26
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,8 @@
1-
import django
2-
3-
from django.conf import settings
4-
5-
6-
# Django 1.5 add support for custom auth user model
7-
if django.VERSION >= (1, 5):
8-
AUTH_USER_MODEL = settings.AUTH_USER_MODEL
9-
else:
10-
AUTH_USER_MODEL = "auth.User"
11-
12-
13-
def old_get_user_model():
14-
return User
15-
161
try:
172
from django.contrib.contenttypes.fields import GenericForeignKey
183
except ImportError:
194
from django.contrib.contenttypes.generic import GenericForeignKey # noqa
205

21-
try:
22-
import importlib
23-
except ImportError:
24-
from django.utils import importlib # noqa
25-
26-
try:
27-
from django.contrib.auth import get_user_model
28-
except ImportError:
29-
from django.contrib.auth.models import User
30-
get_user_model = old_get_user_model
31-
326
try:
337
from urllib import quote
348
except ImportError:

pinax/notifications/conf.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
from __future__ import unicode_literals
22

3+
import importlib
4+
35
from django.conf import settings # noqa
46
from django.core.exceptions import ImproperlyConfigured
57

6-
from .compat import get_model, importlib
8+
from .compat import get_model
79

810
from appconf import AppConf
911

pinax/notifications/engine.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@
55
import base64
66

77
from django.core.mail import mail_admins
8-
from django.contrib.sites.models import Site
98
from django.utils.six.moves import cPickle as pickle # pylint: disable-msg=F
109

10+
from django.contrib.auth import get_user_model
11+
from django.contrib.sites.models import Site
12+
1113
from .lockfile import FileLock, AlreadyLocked, LockTimeout
1214
from .models import NoticeQueueBatch
1315
from .signals import emitted_notices
1416
from . import models as notification
1517

16-
from .compat import get_user_model
1718
from .conf import settings
1819

1920

pinax/notifications/models.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
from django.contrib.contenttypes.models import ContentType
1515

16-
from .compat import AUTH_USER_MODEL, GenericForeignKey
16+
from .compat import GenericForeignKey
1717
from .conf import settings
1818
from .utils import load_media_defaults, notice_setting_for_user
1919

@@ -77,7 +77,7 @@ class NoticeSetting(models.Model):
7777
of a given type to a given medium.
7878
"""
7979

80-
user = models.ForeignKey(AUTH_USER_MODEL, verbose_name=_("user"))
80+
user = models.ForeignKey(settings.AUTH_USER_MODEL, verbose_name=_("user"))
8181
notice_type = models.ForeignKey(NoticeType, verbose_name=_("notice type"))
8282
medium = models.CharField(_("medium"), max_length=1, choices=NOTICE_MEDIA)
8383
send = models.BooleanField(_("send"), default=False)

pinax/notifications/tests/models.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
from django.db import models
22

3-
from ..compat import AUTH_USER_MODEL
3+
from ..conf import settings
44

55

66
class Language(models.Model):
7-
user = models.ForeignKey(AUTH_USER_MODEL)
7+
user = models.ForeignKey(settings.AUTH_USER_MODEL)
88
language = models.CharField("language", max_length=10)

pinax/notifications/tests/test_commands.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
from django.test import TestCase
33
from django.test.utils import override_settings
44

5-
from ..compat import get_user_model
5+
from django.contrib.auth import get_user_model
6+
67
from ..models import NoticeType, queue
78

89

pinax/notifications/tests/test_models.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
import base64
22

3-
from django.contrib.sites.models import Site
43
from django.core import mail
54
from django.utils.six.moves import cPickle as pickle
65
from django.test import TestCase
76
from django.test.utils import override_settings
87

8+
from django.contrib.auth import get_user_model
9+
from django.contrib.sites.models import Site
10+
911
from ..conf import settings
1012
from ..models import NoticeType, NoticeQueueBatch, NoticeSetting
1113
from ..models import LanguageStoreNotAvailable
1214
from ..models import get_notification_language, send_now, send, queue
13-
from ..compat import get_user_model
1415

1516
from .models import Language
1617

pinax/notifications/tests/test_views.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
from django.core.urlresolvers import reverse
22
from django.test import TestCase, RequestFactory
33

4-
from ..compat import get_user_model
4+
from django.contrib.auth import get_user_model
5+
56
from ..models import NoticeType, NoticeSetting
67
from ..views import NoticeSettingsView
78

0 commit comments

Comments
 (0)