Skip to content

Commit a0bc3f7

Browse files
committed
kernel/power/energy_model.c: fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: "Rafael J. Wysocki" <[email protected]> Cc: Pavel Machek <[email protected]> Cc: Len Brown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 5f51399 commit a0bc3f7

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

kernel/power/energy_model.c

+1-4
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,7 @@ static void em_debug_create_pd(struct device *dev)
8787

8888
static void em_debug_remove_pd(struct device *dev)
8989
{
90-
struct dentry *debug_dir;
91-
92-
debug_dir = debugfs_lookup(dev_name(dev), rootdir);
93-
debugfs_remove_recursive(debug_dir);
90+
debugfs_lookup_and_remove(dev_name(dev), rootdir);
9491
}
9592

9693
static int __init em_debug_init(void)

0 commit comments

Comments
 (0)