Skip to content

Commit 1e18572

Browse files
zijun-huakpm00
authored andcommitted
kernel/resource: simplify API __devm_release_region() implementation
Simplify __devm_release_region() implementation by dedicated API devres_release() which have below advantages than current __release_region() + devres_destroy(): It is simpler if __devm_release_region() is undoing what __devm_request_region() did, otherwise, it can avoid wrong and undesired __release_region(). Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Zijun Hu <[email protected]> Cc: Andy Shevchenko <[email protected]> Cc: Bjorn Helgaas <[email protected]> Cc: Ilpo Järvinen <[email protected]> Cc: Mika Westerberg <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 79ada2a commit 1e18572

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

kernel/resource.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1683,8 +1683,7 @@ void __devm_release_region(struct device *dev, struct resource *parent,
16831683
{
16841684
struct region_devres match_data = { parent, start, n };
16851685

1686-
__release_region(parent, start, n);
1687-
WARN_ON(devres_destroy(dev, devm_region_release, devm_region_match,
1686+
WARN_ON(devres_release(dev, devm_region_release, devm_region_match,
16881687
&match_data));
16891688
}
16901689
EXPORT_SYMBOL(__devm_release_region);

0 commit comments

Comments
 (0)