Add comprehensive tests for Phase 3 RSC utility methods

Add tests for the three RSC utility methods moved to Pro gem:

- rsc_support_enabled?: Tests enabled/disabled states
- rsc_bundle_js_file_path: Tests delegation to bundle_js_file_path,
  caching behavior in development vs production
- react_client_manifest_file_path: Tests packer integration with
  dev server running/not running, caching behavior
- react_server_client_manifest_file_path: Tests delegation,
  caching behavior, error handling when manifest is nil

Total: ~210 lines of tests ensuring all RSC utility methods work
correctly in the Pro gem with proper caching and error handling.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: AbanoubGhadban

.claude/.fuse_hidden000017da00000005

@@ -0,0 +1,29 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(git commit:*)",
+      "Bash(yarn build:*)",
+      "Bash(bundle exec rake:*)",
+      "Bash(gh pr view:*)",
+      "Bash(gh run list:*)",
+      "Bash(gh pr checks:*)",
+      "Bash(gh run view:*)",
+      "Bash(bundle exec rubocop:*)",
+      "Bash(gh pr comment 1854 --body \"$(cat <<''EOF''\n## Closing this PR - Change in Plan\n\nAfter discussion with @justin808, we''ve decided on a different approach:\n\n**New Plan:**\n- Keep the immediate hydration Ruby code in the MIT gem (move from `lib/react_on_rails/pro/` to regular `lib/react_on_rails/`)\n- Make it disabled by default when Pro gem is not installed\n- Automatically enable it when Pro gem is present\n- The actual functionality remains in the Pro npm package, so users can''t hack it by editing Ruby code\n\n**Benefits:**\n- Marketing visibility: All users see the Pro feature exists\n- Professional presentation: Non-intrusive way to inform users about Pro features\n- No security risk: Core logic stays in Pro npm package\n- Clean separation: Ruby code in MIT, functionality in Pro packages\n\n**Next Steps:**\n- Will open a new, simpler PR that just moves `lib/react_on_rails/pro/` code to MIT license\n- Update LICENSE.md accordingly\n- Update documentation\n\nThis PR did valuable work in establishing the data enhancement pattern and will serve as reference, but the simpler approach is more aligned with business goals.\nEOF\n)\")",
+      "Bash(gh pr close:*)",
+      "Bash(git checkout:*)",
+      "Bash(git pull:*)",
+      "Bash(git fetch:*)",
+      "Bash(bundle exec rspec:*)",
+      "Bash(git add:*)",
+      "Bash(git push:*)",
+      "Bash(git revert:*)",
+      "Bash(git rm:*)",
+      "Bash(gh pr list:*)",
+      "Bash(gh issue create --title \"Migrate React on Rails Pro CI from CircleCI to GitHub Actions\" --body \"$(cat <<''EOF''\n## Summary\n\nMigrate the React on Rails Pro package CI/CD pipeline from CircleCI to GitHub Actions to consolidate all testing infrastructure in one platform.\n\n## Background\n\nCurrently:\n- **Main package** (react-on-rails): Uses GitHub Actions (`.github/workflows/*.yml`)\n- **Pro package** (react-on-rails-pro): Uses CircleCI (`.circleci/config.yml`)\n\nThis creates maintenance overhead and splits CI visibility across two platforms.\n\n## Migration Plan\n\n### CircleCI Jobs to Migrate (10 jobs total):\n\n1. **lint-js-and-ruby** - Linting for Pro package (JS, Ruby, formatting, TypeScript)\n2. **install-package-node-packages** - Install Pro package node modules (caching job)\n3. **install-dummy-app-node-packages** - Install dummy app node modules (caching job)\n4. **install-package-ruby-gems** - Install Pro package Ruby gems (caching job)\n5. **install-dummy-app-ruby-gems** - Install dummy app Ruby gems (caching job)\n6. **build-dummy-app-webpack-test-bundles** - Build webpack test bundles\n7. **package-js-tests** - Jest unit tests for Pro package\n8. **rspec-package-specs** - RSpec tests for Pro package\n9. **rspec-dummy-app-node-renderer** - RSpec integration tests with Node renderer (includes test splitting)\n10. **dummy-app-node-renderer-e2-tests** - Playwright E2E tests (requires Redis service)\n\n### New GitHub Actions Workflows (3 files):\n\n1. **`.github/workflows/pro-lint.yml`** - Linting workflow\n2. **`.github/workflows/pro-package-tests.yml`** - Unit tests workflow\n3. **`.github/workflows/pro-integration-tests.yml`** - Integration & E2E tests workflow\n\n### Key Implementation Details:\n\n- **Test Parallelization**: Use GitHub Actions matrix strategy with sharding for RSpec tests (replaces CircleCI test splitting)\n- **Redis Service**: Use GitHub Actions service containers for E2E tests\n- **Caching**: Migrate to `actions/cache@v4` with similar key patterns\n- **Ruby/Node Versions**: Ruby 3.3.7, Node 20/22\n- **Browser Tests**: Chrome installation for Capybara/Playwright tests\n- **Working Directory**: All commands run from `react_on_rails_pro/`\n- **Artifacts**: Store test results, screenshots, and logs\n\n### Migration Strategy:\n\n✅ **Phase 1**: Create GitHub Actions workflows (keep CircleCI running in parallel)\n✅ **Phase 2**: Verify all tests pass and artifacts are stored correctly  \n✅ **Phase 3**: Monitor both systems for 1-2 weeks\n✅ **Phase 4**: Remove CircleCI config once GitHub Actions is proven stable\n\n### Technical Feasibility:\n\n✅ All CircleCI features can be replicated in GitHub Actions\n✅ Test splitting: Achievable with matrix strategy + RSpec sharding\n✅ Redis service: Native support via service containers\n✅ Background processes: Works identically in both platforms\n✅ Caching: Full support with similar patterns\n✅ Artifacts & test results: Full support\n\n**No blockers identified** - migration is straightforward and low-risk.\n\n## Benefits\n\n- ✅ Unified CI platform (all workflows in GitHub Actions)\n- ✅ Better visibility (all CI results in one place)\n- ✅ Reduced maintenance overhead\n- ✅ Cost consolidation\n- ✅ Consistent workflow patterns across main and pro packages\n\n## Related\n\n- Main package workflows: `.github/workflows/main.yml`, `lint-js-and-ruby.yml`, etc.\n- CircleCI config: `.circleci/config.yml`\nEOF\n)\")",
+      "Bash(gh api:*)"
+    ],
+    "deny": [],
+    "ask": []
+  }
+}

react_on_rails_pro/spec/react_on_rails_pro/utils_spec.rb

@@ -222,6 +222,218 @@ module ReactOnRailsPro
       it { expect(printable_cache_key).to eq("1_2_3_4_5") }
     end
 
+    describe ".rsc_support_enabled?" do
+      context "when RSC support is enabled" do
+        before do
+          allow(ReactOnRailsPro.configuration).to receive(:enable_rsc_support).and_return(true)
+          described_class.instance_variable_set(:@rsc_support_enabled, nil)
+        end
+
+        it "returns true" do
+          expect(described_class.rsc_support_enabled?).to be(true)
+        end
+      end
+
+      context "when RSC support is disabled" do
+        before do
+          allow(ReactOnRailsPro.configuration).to receive(:enable_rsc_support).and_return(false)
+          described_class.instance_variable_set(:@rsc_support_enabled, nil)
+        end
+
+        it "returns false" do
+          expect(described_class.rsc_support_enabled?).to be(false)
+        end
+      end
+    end
+
+    describe ".rsc_bundle_js_file_path" do
+      before do
+        described_class.instance_variable_set(:@rsc_bundle_path, nil)
+        allow(ReactOnRailsPro.configuration).to receive(:rsc_bundle_js_file).and_return("rsc-bundle.js")
+      end
+
+      after do
+        described_class.instance_variable_set(:@rsc_bundle_path, nil)
+      end
+
+      it "calls bundle_js_file_path with the rsc_bundle_js_file name" do
+        allow(ReactOnRails::Utils).to receive(:bundle_js_file_path).with("rsc-bundle.js")
+                                                                   .and_return("/some/path/rsc-bundle.js")
+
+        result = described_class.rsc_bundle_js_file_path
+
+        expect(ReactOnRails::Utils).to have_received(:bundle_js_file_path).with("rsc-bundle.js")
+        expect(result).to eq("/some/path/rsc-bundle.js")
+      end
+
+      it "caches the path when not in development" do
+        allow(Rails.env).to receive(:development?).and_return(false)
+        allow(ReactOnRails::Utils).to receive(:bundle_js_file_path).with("rsc-bundle.js")
+                                                                   .and_return("/some/path/rsc-bundle.js")
+
+        result1 = described_class.rsc_bundle_js_file_path
+        result2 = described_class.rsc_bundle_js_file_path
+
+        expect(ReactOnRails::Utils).to have_received(:bundle_js_file_path).once.with("rsc-bundle.js")
+        expect(result1).to eq("/some/path/rsc-bundle.js")
+        expect(result2).to eq("/some/path/rsc-bundle.js")
+      end
+
+      it "does not cache the path in development" do
+        allow(Rails.env).to receive(:development?).and_return(true)
+        allow(ReactOnRails::Utils).to receive(:bundle_js_file_path).with("rsc-bundle.js")
+                                                                   .and_return("/some/path/rsc-bundle.js")
+
+        result1 = described_class.rsc_bundle_js_file_path
+        result2 = described_class.rsc_bundle_js_file_path
+
+        expect(ReactOnRails::Utils).to have_received(:bundle_js_file_path).twice.with("rsc-bundle.js")
+        expect(result1).to eq("/some/path/rsc-bundle.js")
+        expect(result2).to eq("/some/path/rsc-bundle.js")
+      end
+    end
+
+    describe ".react_client_manifest_file_path" do
+      before do
+        described_class.instance_variable_set(:@react_client_manifest_path, nil)
+        allow(ReactOnRailsPro.configuration).to receive(:react_client_manifest_file)
+          .and_return("react-client-manifest.json")
+      end
+
+      after do
+        described_class.instance_variable_set(:@react_client_manifest_path, nil)
+      end
+
+      context "when using packer" do
+        let(:public_output_path) { "/path/to/public/webpack/dev" }
+
+        before do
+          allow(::Shakapacker).to receive_message_chain("config.public_output_path")
+            .and_return(Pathname.new(public_output_path))
+          allow(::Shakapacker).to receive_message_chain("config.public_path")
+            .and_return(Pathname.new("/path/to/public"))
+        end
+
+        context "when dev server is running" do
+          before do
+            allow(::Shakapacker).to receive(:dev_server).and_return(
+              instance_double(
+                ::Shakapacker::DevServer,
+                running?: true,
+                protocol: "http",
+                host_with_port: "localhost:3035"
+              )
+            )
+          end
+
+          it "returns manifest URL with dev server path" do
+            expected_url = "http://localhost:3035/webpack/dev/react-client-manifest.json"
+            expect(described_class.react_client_manifest_file_path).to eq(expected_url)
+          end
+        end
+
+        context "when dev server is not running" do
+          before do
+            allow(::Shakapacker).to receive_message_chain("dev_server.running?")
+              .and_return(false)
+          end
+
+          it "returns file path to the manifest" do
+            expected_path = File.join(public_output_path, "react-client-manifest.json")
+            expect(described_class.react_client_manifest_file_path).to eq(expected_path)
+          end
+        end
+      end
+
+      it "caches the path when not in development" do
+        allow(Rails.env).to receive(:development?).and_return(false)
+        allow(ReactOnRails::PackerUtils).to receive(:asset_uri_from_packer)
+          .with("react-client-manifest.json")
+          .and_return("/some/path/react-client-manifest.json")
+
+        result1 = described_class.react_client_manifest_file_path
+        result2 = described_class.react_client_manifest_file_path
+
+        expect(ReactOnRails::PackerUtils).to have_received(:asset_uri_from_packer).once
+        expect(result1).to eq("/some/path/react-client-manifest.json")
+        expect(result2).to eq("/some/path/react-client-manifest.json")
+      end
+
+      it "does not cache the path in development" do
+        allow(Rails.env).to receive(:development?).and_return(true)
+        allow(ReactOnRails::PackerUtils).to receive(:asset_uri_from_packer)
+          .with("react-client-manifest.json")
+          .and_return("/some/path/react-client-manifest.json")
+
+        result1 = described_class.react_client_manifest_file_path
+        result2 = described_class.react_client_manifest_file_path
+
+        expect(ReactOnRails::PackerUtils).to have_received(:asset_uri_from_packer).twice
+        expect(result1).to eq("/some/path/react-client-manifest.json")
+        expect(result2).to eq("/some/path/react-client-manifest.json")
+      end
+    end
+
+    describe ".react_server_client_manifest_file_path" do
+      let(:asset_name) { "react-server-client-manifest.json" }
+
+      before do
+        described_class.instance_variable_set(:@react_server_manifest_path, nil)
+        allow(ReactOnRailsPro.configuration).to receive(:react_server_client_manifest_file).and_return(asset_name)
+        allow(Rails.env).to receive(:development?).and_return(false)
+      end
+
+      after do
+        described_class.instance_variable_set(:@react_server_manifest_path, nil)
+      end
+
+      it "calls bundle_js_file_path with the correct asset name and returns its value" do
+        allow(ReactOnRails::Utils).to receive(:bundle_js_file_path).with(asset_name)
+                                                                   .and_return("/some/path/#{asset_name}")
+
+        result = described_class.react_server_client_manifest_file_path
+
+        expect(ReactOnRails::Utils).to have_received(:bundle_js_file_path).with(asset_name)
+        expect(result).to eq("/some/path/#{asset_name}")
+      end
+
+      it "caches the path when not in development" do
+        allow(ReactOnRails::Utils).to receive(:bundle_js_file_path).with(asset_name)
+                                                                   .and_return("/some/path/#{asset_name}")
+
+        result1 = described_class.react_server_client_manifest_file_path
+        result2 = described_class.react_server_client_manifest_file_path
+
+        expect(ReactOnRails::Utils).to have_received(:bundle_js_file_path).once.with(asset_name)
+        expect(result1).to eq("/some/path/#{asset_name}")
+        expect(result2).to eq("/some/path/#{asset_name}")
+      end
+
+      it "does not cache the path in development" do
+        allow(Rails.env).to receive(:development?).and_return(true)
+        allow(ReactOnRails::Utils).to receive(:bundle_js_file_path).with(asset_name)
+                                                                   .and_return("/some/path/#{asset_name}")
+
+        result1 = described_class.react_server_client_manifest_file_path
+        result2 = described_class.react_server_client_manifest_file_path
+
+        expect(ReactOnRails::Utils).to have_received(:bundle_js_file_path).twice.with(asset_name)
+        expect(result1).to eq("/some/path/#{asset_name}")
+        expect(result2).to eq("/some/path/#{asset_name}")
+      end
+
+      context "when manifest file name is nil" do
+        before do
+          allow(ReactOnRailsPro.configuration).to receive(:react_server_client_manifest_file).and_return(nil)
+        end
+
+        it "raises an error" do
+          expect { described_class.react_server_client_manifest_file_path }
+            .to raise_error(ReactOnRailsPro::Error, /react_server_client_manifest_file is nil/)
+        end
+      end
+    end
+
     describe ".pro_attribution_comment" do
       context "when license is valid and not in grace period" do
         before do