You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow up on this issue #59
This gem expects a log level to be explicitly provided in the yaml/environment.rb files failing which it assumes the WARN level as seen here
Will it better if we fallback to Rails.logger.level if nothing is specified? I think users would expect LogStasher to use the same severity level as configured for Rails.
I am willing to make this change if it sounds good, or atleast add the current way to documentation because I suspect this is going to be a breaking change
The text was updated successfully, but these errors were encountered:
Thank you for posting about this! I have been wondering about this for years (but not enough to actually look deeply into this apparently) and was very confused why the Rails log level was not being respected. I agree that falling back to Rails.logger.level would be a more expected default behavior.
This is a follow up on this issue #59
This gem expects a log level to be explicitly provided in the yaml/environment.rb files failing which it assumes the
WARN
level as seen herelogstasher/lib/logstasher.rb
Line 116 in aca2843
Will it better if we fallback to
Rails.logger.level
if nothing is specified? I think users would expect LogStasher to use the same severity level as configured for Rails.I am willing to make this change if it sounds good, or atleast add the current way to documentation because I suspect this is going to be a breaking change
The text was updated successfully, but these errors were encountered: