Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Optimization: Avoid creating new CCByteBufs all the time #27

Open
shBLOCK opened this issue Aug 31, 2024 · 0 comments
Open

[Python] Optimization: Avoid creating new CCByteBufs all the time #27

shBLOCK opened this issue Aug 31, 2024 · 0 comments
Labels
enhancement New feature or request python

Comments

@shBLOCK
Copy link
Owner

shBLOCK commented Aug 31, 2024

Currently, a new CCByteBuf is created for every send operation.
CCByteBufs can't be easily reused since we use memoryvviews of them for sending, which may result in race conditions where the buffer (thus the view) gets overridden / cleared before the message actually gets sent.
Further investigation needed: maybe it's just because we didn't call memoryview.release()?

@shBLOCK shBLOCK added enhancement New feature or request python labels Aug 31, 2024
@shBLOCK shBLOCK moved this to Long Term in CodeCraft Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
Status: In Progress
Development

No branches or pull requests

1 participant