Merge rust-lang#917

917: Add lints to require Debug and Copy on all types that can be r=sgrif

@sgrif I thought you had said that the lint would know if it wasn't possible to derive Debug.... that doesn't appear to be the case 😢 Soo I'm allowing it in places!

Author: bors-voyager[bot]

src/app.rs

@@ -16,6 +16,8 @@ use {db, Config};
 
 /// The `App` struct holds the main components of the application like
 /// the database connection pool and configurations
+// The db, oauth, and git2 types don't implement debug.
+#[allow(missing_debug_implementations)]
 pub struct App {
     /// The database connection pool
     pub database: db::Pool,
@@ -40,6 +42,8 @@ pub struct App {
 }
 
 /// The `AppMiddleware` injects an `App` instance into the `Request` extensions
+// Can't derive Debug because `App` can't.
+#[allow(missing_debug_implementations)]
 pub struct AppMiddleware {
     app: Arc<App>,
 }

src/badge.rs

@@ -42,7 +42,7 @@ pub enum Badge {
     Maintenance { value: MaintenanceValue },
 }
 
-#[derive(Debug, PartialEq, Clone, Deserialize, Serialize)]
+#[derive(Debug, PartialEq, Clone, Copy, Deserialize, Serialize)]
 #[serde(rename_all = "kebab-case")]
 pub enum MaintenanceValue {
     ActivelyDeveloped,
@@ -81,7 +81,7 @@ impl Badge {
     ) -> QueryResult<Vec<&'a str>> {
         use diesel::{insert, delete};
 
-        #[derive(Insertable)]
+        #[derive(Insertable, Debug)]
         #[table_name = "badges"]
         struct NewBadge<'a> {
             crate_id: i32,

src/category.rs

@@ -22,7 +22,7 @@ pub struct Category {
     pub created_at: Timespec,
 }
 
-#[derive(Associations, Insertable, Identifiable, Debug)]
+#[derive(Associations, Insertable, Identifiable, Debug, Clone, Copy)]
 #[belongs_to(Category)]
 #[belongs_to(Crate)]
 #[table_name = "crates_categories"]

src/db.rs

@@ -128,8 +128,11 @@ pub fn diesel_pool(
     r2d2::Pool::new(config, manager).unwrap()
 }
 
+#[derive(Clone, Copy, Debug)]
 pub struct TransactionMiddleware;
 
+// Can't derive Debug because of LazyCell and App.
+#[allow(missing_debug_implementations)]
 pub struct Transaction {
     // fields are destructed top-to-bottom so ensure we destroy them in the
     // right order.

src/dist.rs

@@ -6,6 +6,8 @@ use conduit_middleware::AroundMiddleware;
 
 use util::RequestProxy;
 
+// Can't derive debug because of Handler and Static.
+#[allow(missing_debug_implementations)]
 pub struct Middleware {
     handler: Option<Box<Handler>>,
     dist: Static,

src/download.rs

@@ -8,7 +8,7 @@ use Model;
 use schema::version_downloads;
 use version::Version;
 
-#[derive(Queryable, Identifiable, Associations, Debug)]
+#[derive(Queryable, Identifiable, Associations, Debug, Clone, Copy)]
 #[belongs_to(Version)]
 pub struct VersionDownload {
     pub id: i32,
@@ -19,7 +19,7 @@ pub struct VersionDownload {
     pub processed: bool,
 }
 
-#[derive(Insertable, Debug)]
+#[derive(Insertable, Debug, Clone, Copy)]
 #[table_name = "version_downloads"]
 struct NewVersionDownload(
     #[column_name(version_id)]

src/keyword.rs

@@ -22,7 +22,7 @@ pub struct Keyword {
     pub created_at: Timespec,
 }
 
-#[derive(Associations, Insertable, Identifiable, Debug)]
+#[derive(Associations, Insertable, Identifiable, Debug, Clone, Copy)]
 #[belongs_to(Keyword)]
 #[belongs_to(Crate)]
 #[table_name = "crates_keywords"]
@@ -51,7 +51,7 @@ impl Keyword {
         use diesel::pg::upsert::*;
         use diesel::expression::dsl::any;
 
-        #[derive(Insertable)]
+        #[derive(Insertable, Debug, Clone, Copy)]
         #[table_name = "keywords"]
         struct NewKeyword<'a> {
             keyword: &'a str,
@@ -198,7 +198,7 @@ mod tests {
     use diesel;
     use diesel::connection::SimpleConnection;
 
-    #[derive(Insertable)]
+    #[derive(Insertable, Debug, Clone, Copy)]
     #[table_name = "keywords"]
     struct NewKeyword<'a> {
         keyword: &'a str,

src/krate.rs

@@ -44,7 +44,7 @@ use {Model, User, Keyword, Version, Category, Badge, Replica};
 /// and are possibly of malicious intent e.g. ad tracking networks, etc.
 const DOCUMENTATION_BLACKLIST: [&'static str; 1] = ["rust-ci.org"];
 
-#[derive(Debug, Insertable, Queryable, Identifiable, Associations, AsChangeset)]
+#[derive(Debug, Insertable, Queryable, Identifiable, Associations, AsChangeset, Clone, Copy)]
 #[belongs_to(Crate)]
 #[primary_key(crate_id, date)]
 #[table_name = "crate_downloads"]
@@ -1381,7 +1381,7 @@ pub fn downloads(req: &mut Request) -> CargoResult<Response> {
     }))
 }
 
-#[derive(Insertable, Queryable, Identifiable, Associations)]
+#[derive(Insertable, Queryable, Identifiable, Associations, Clone, Copy, Debug)]
 #[belongs_to(User)]
 #[primary_key(user_id, crate_id)]
 #[table_name = "follows"]

src/lib.rs

@@ -5,6 +5,7 @@
 //! [krate](krate/index.html), [user](user/index.html) and [version](version/index.html) modules.
 
 #![deny(warnings)]
+#![deny(missing_debug_implementations, missing_copy_implementations)]
 #![cfg_attr(feature = "clippy", feature(plugin))]
 #![cfg_attr(feature = "clippy", plugin(clippy))]
 

src/owner.rs

@@ -8,7 +8,7 @@ use schema::*;
 use util::{CargoResult, human};
 use {Model, User, Crate};
 
-#[derive(Insertable, Associations, Identifiable, Debug)]
+#[derive(Insertable, Associations, Identifiable, Debug, Clone, Copy)]
 #[belongs_to(Crate)]
 #[belongs_to(User, foreign_key = "owner_id")]
 #[belongs_to(Team, foreign_key = "owner_id")]
@@ -21,7 +21,7 @@ pub struct CrateOwner {
     pub owner_kind: i32,
 }
 
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy)]
 #[repr(u32)]
 pub enum OwnerKind {
     User = 0,
@@ -74,7 +74,7 @@ pub struct EncodableOwner {
 
 /// Access rights to the crate (publishing and ownership management)
 /// NOTE: The order of these variants matters!
-#[derive(PartialEq, Eq, PartialOrd, Ord, Debug)]
+#[derive(PartialEq, Eq, PartialOrd, Ord, Debug, Clone, Copy)]
 pub enum Rights {
     None,
     Publish,

src/token.rs

@@ -23,7 +23,7 @@ pub struct ApiToken {
 }
 
 /// The serialization format for the `ApiToken` model without its token value.
-#[derive(Deserialize, Serialize)]
+#[derive(Deserialize, Serialize, Debug)]
 pub struct EncodableApiToken {
     pub id: i32,
     pub name: String,
@@ -34,7 +34,7 @@ pub struct EncodableApiToken {
 /// The serialization format for the `ApiToken` model with its token value.
 /// This should only be used when initially creating a new token to minimize
 /// the chance of token leaks.
-#[derive(Deserialize, Serialize)]
+#[derive(Deserialize, Serialize, Debug)]
 pub struct EncodableApiTokenWithToken {
     pub id: i32,
     pub name: String,
@@ -47,7 +47,7 @@ impl ApiToken {
     /// Generates a new named API token for a user
     pub fn insert(conn: &PgConnection, user_id: i32, name: &str) -> QueryResult<ApiToken> {
         #[table_name = "api_tokens"]
-        #[derive(Insertable, AsChangeset)]
+        #[derive(Insertable, AsChangeset, Debug)]
         struct NewApiToken<'a> {
             user_id: i32,
             name: &'a str,

src/uploaders.rs

@@ -169,6 +169,8 @@ impl Uploader {
     }
 }
 
+// Can't derive Debug because of App.
+#[allow(missing_debug_implementations)]
 pub struct Bomb {
     app: Arc<App>,
     pub path: Option<String>,

src/user/middleware.rs

@@ -9,6 +9,7 @@ use db::RequestTransaction;
 use super::User;
 use util::errors::{CargoResult, Unauthorized, ChainError, std_error};
 
+#[derive(Debug, Clone, Copy)]
 pub struct Middleware;
 
 #[derive(Debug, Copy, Clone, Eq, PartialEq)]

src/util/errors.rs

@@ -223,6 +223,7 @@ impl CargoError for ConcreteCargoError {
     }
 }
 
+#[derive(Debug, Clone, Copy)]
 pub struct NotFound;
 
 impl CargoError for NotFound {
@@ -245,6 +246,7 @@ impl fmt::Display for NotFound {
     }
 }
 
+#[derive(Debug, Clone, Copy)]
 pub struct Unauthorized;
 
 impl CargoError for Unauthorized {

src/util/hasher.rs

@@ -2,6 +2,8 @@ use std::io::prelude::*;
 use std::io;
 use openssl::hash::{Hasher, MessageDigest};
 
+// Can't derive debug because of Hasher.
+#[allow(missing_debug_implementations)]
 pub struct HashingReader<R> {
     inner: R,
     hasher: Hasher,

src/util/head.rs

@@ -6,6 +6,8 @@ use conduit_middleware::AroundMiddleware;
 
 use util::RequestProxy;
 
+// Can't derive debug because of Handler.
+#[allow(missing_debug_implementations)]
 #[derive(Default)]
 pub struct Head {
     handler: Option<Box<Handler>>,

src/util/io_util.rs

@@ -2,6 +2,7 @@ use std::io::prelude::*;
 use std::io;
 use std::mem;
 
+#[derive(Debug)]
 pub struct LimitErrorReader<R> {
     inner: io::Take<R>,
 }

src/util/lazy_cell.rs

@@ -11,6 +11,8 @@
 use std::cell::RefCell;
 use std::mem;
 
+// Don't want to only be able to store T: Debug things.
+#[allow(missing_debug_implementations)]
 pub struct LazyCell<T> {
     inner: RefCell<Option<T>>,
 }

src/util/mod.rs

@@ -102,6 +102,8 @@ impl<'a> RequestUtils for Request + 'a {
     }
 }
 
+// Can't Copy or Debug the fn.
+#[allow(missing_debug_implementations, missing_copy_implementations)]
 pub struct C(pub fn(&mut Request) -> CargoResult<Response>);
 
 impl Handler for C {
@@ -122,6 +124,7 @@ impl Handler for C {
     }
 }
 
+#[derive(Debug)]
 pub struct R<H>(pub Arc<H>);
 
 impl<H: Handler> Handler for R<H> {
@@ -136,6 +139,8 @@ impl<H: Handler> Handler for R<H> {
     }
 }
 
+// Can't derive Debug because of RouteBuilder.
+#[allow(missing_debug_implementations)]
 pub struct R404(pub RouteBuilder);
 
 impl Handler for R404 {

src/util/request_proxy.rs

@@ -5,6 +5,8 @@ use conduit;
 use conduit::Request;
 use semver;
 
+// Can't derive Debug because of Request.
+#[allow(missing_debug_implementations)]
 pub struct RequestProxy<'a> {
     pub other: &'a mut (Request + 'a),
     pub path: Option<&'a str>,