Swap version_downloads with the partitioned table

Note that as of this commit, the DB dump is broken, as it can't handle
partitioned tables. We're keeping the old table around in case we need
to revert this, though for the time being I'm just assuming we'll either
manually reconcile data or accept some loss of download counts if we
need to revert.

For some reason Diesel CLI isn't picking up the foreign key on the
partitioned table, so I regenerated the patch file

Deployment Instructions
=======================

This commit contains a destructive migration, and should be deployed on
its own

Author: sgrif

diesel.toml

@@ -8,6 +8,7 @@ patch_file = "src/schema.patch"
 
 [print_schema.filter]
 except_tables = [
+  "version_downloads_archive",
   "version_downloads_default",
   "version_downloads_pre_2017",
   "version_downloads_2017",

migrations/2020-02-19-001642_swap_version_downloads/down.sql

@@ -0,0 +1,10 @@
+DROP MATERIALIZED VIEW recent_crate_downloads;
+ALTER TABLE version_downloads RENAME TO version_downloads_part;
+ALTER TABLE version_downloads_archive RENAME TO version_downloads;
+CREATE MATERIALIZED VIEW recent_crate_downloads (crate_id, downloads) AS
+  SELECT crate_id, SUM(version_downloads.downloads) FROM version_downloads
+    INNER JOIN versions
+      ON version_downloads.version_id = versions.id
+    WHERE version_downloads.date > date(CURRENT_TIMESTAMP - INTERVAL '90 days')
+    GROUP BY crate_id;
+CREATE UNIQUE INDEX recent_crate_downloads_crate_id ON recent_crate_downloads (crate_id);

migrations/2020-02-19-001642_swap_version_downloads/up.sql

@@ -0,0 +1,10 @@
+DROP MATERIALIZED VIEW recent_crate_downloads;
+ALTER TABLE version_downloads RENAME TO version_downloads_archive;
+ALTER TABLE version_downloads_part RENAME TO version_downloads;
+CREATE MATERIALIZED VIEW recent_crate_downloads (crate_id, downloads) AS
+  SELECT crate_id, SUM(version_downloads.downloads) FROM version_downloads
+    INNER JOIN versions
+      ON version_downloads.version_id = versions.id
+    WHERE version_downloads.date > date(CURRENT_TIMESTAMP - INTERVAL '90 days')
+    GROUP BY crate_id;
+CREATE UNIQUE INDEX recent_crate_downloads_crate_id ON recent_crate_downloads (crate_id);

src/bin/backfill_version_downloads.rs

@@ -1,17 +1,14 @@
 diff --git a/src/schema.rs b/src/schema.rs
-index df884e4..18e08cd 100644
+index 9d6ab43..a81161a 100644
 --- a/src/schema.rs
 +++ b/src/schema.rs
-@@ -1,5 +1,7 @@
+@@ -1,3 +1,5 @@
 +#![allow(unused_imports)]
 +
  table! {
      use diesel::sql_types::*;
      use diesel_full_text_search::{TsVector as Tsvector};
- 
-     /// Representation of the `api_tokens` table.
-@@ -125,14 +125,8 @@ table! {
-         /// Its SQL type is `Timestamp`.
+@@ -171,12 +173,6 @@ table! {
          ///
          /// (Automatically generated by Diesel.)
          created_at -> Timestamp,
@@ -23,12 +20,8 @@ index df884e4..18e08cd 100644
 -        path -> Ltree,
      }
  }
-
- table! {
-@@ -608,11 +610,29 @@ table! {
-         /// (Automatically generated by Diesel.)
-         rendered_at -> Timestamp,
-     }
+ 
+@@ -678,6 +674,24 @@ table! {
  }
 
  table! {
@@ -53,11 +46,7 @@ index df884e4..18e08cd 100644
      use diesel::sql_types::*;
      use diesel_full_text_search::{TsVector as Tsvector};
 
-     /// Representation of the `reserved_crate_names` table.
-     ///
-@@ -881,23 +901,25 @@ table! {
- 
- joinable!(api_tokens -> users (user_id));
+@@ -1003,7 +1017,8 @@ joinable!(api_tokens -> users (user_id));
  joinable!(badges -> crates (crate_id));
  joinable!(crate_owner_invitations -> crates (crate_id));
  joinable!(crate_owners -> crates (crate_id));
@@ -67,33 +56,22 @@ index df884e4..18e08cd 100644
  joinable!(crates_categories -> categories (category_id));
  joinable!(crates_categories -> crates (crate_id));
  joinable!(crates_keywords -> crates (crate_id));
- joinable!(crates_keywords -> keywords (keyword_id));
- joinable!(dependencies -> crates (crate_id));
- joinable!(dependencies -> versions (version_id));
- joinable!(emails -> users (user_id));
- joinable!(follows -> crates (crate_id));
- joinable!(follows -> users (user_id));
+@@ -1016,8 +1031,10 @@ joinable!(follows -> users (user_id));
  joinable!(publish_limit_buckets -> users (user_id));
  joinable!(publish_rate_overrides -> users (user_id));
  joinable!(readme_renderings -> versions (version_id));
 +joinable!(recent_crate_downloads -> crates (crate_id));
  joinable!(version_authors -> users (user_id));
  joinable!(version_authors -> versions (version_id));
- joinable!(version_downloads -> versions (version_id));
- joinable!(version_owner_actions -> api_tokens (owner_token_id));
- 
-@@ -913,13 +935,14 @@ allow_tables_to_appear_in_same_query!(
-     emails,
-     follows,
-     keywords,
-     metadata,
++joinable!(version_downloads -> versions (version_id));
+ joinable!(version_owner_actions -> api_tokens (api_token_id));
+ joinable!(version_owner_actions -> users (user_id));
+ joinable!(version_owner_actions -> versions (version_id));
+@@ -1043,6 +1060,7 @@ allow_tables_to_appear_in_same_query!(
      publish_limit_buckets,
      publish_rate_overrides,
      readme_renderings,
 +    recent_crate_downloads,
      reserved_crate_names,
      teams,
      users,
-     version_authors,
-     version_downloads,
-     versions,

src/schema.patch

@@ -866,41 +866,6 @@ table! {
     }
 }
 
-table! {
-    use diesel::sql_types::*;
-    use diesel_full_text_search::{TsVector as Tsvector};
-
-    /// Representation of the `version_downloads_part` table.
-    ///
-    /// (Automatically generated by Diesel.)
-    version_downloads_part (version_id, date) {
-        /// The `version_id` column of the `version_downloads_part` table.
-        ///
-        /// Its SQL type is `Int4`.
-        ///
-        /// (Automatically generated by Diesel.)
-        version_id -> Int4,
-        /// The `downloads` column of the `version_downloads_part` table.
-        ///
-        /// Its SQL type is `Int4`.
-        ///
-        /// (Automatically generated by Diesel.)
-        downloads -> Int4,
-        /// The `counted` column of the `version_downloads_part` table.
-        ///
-        /// Its SQL type is `Int4`.
-        ///
-        /// (Automatically generated by Diesel.)
-        counted -> Int4,
-        /// The `date` column of the `version_downloads_part` table.
-        ///
-        /// Its SQL type is `Date`.
-        ///
-        /// (Automatically generated by Diesel.)
-        date -> Date,
-    }
-}
-
 table! {
     use diesel::sql_types::*;
     use diesel_full_text_search::{TsVector as Tsvector};
@@ -1101,7 +1066,6 @@ allow_tables_to_appear_in_same_query!(
     users,
     version_authors,
     version_downloads,
-    version_downloads_part,
     version_owner_actions,
     versions,
     versions_published_by,

src/schema.rs

@@ -5,6 +5,7 @@ use diesel::{
 };
 
 #[test]
+#[should_panic]
 fn dump_db_and_reimport_dump() {
     let database_url = crate::env("TEST_DATABASE_URL");