Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewDeckController sealed #3

Open
Sbou opened this issue Feb 1, 2013 · 1 comment
Open

ViewDeckController sealed #3

Sbou opened this issue Feb 1, 2013 · 1 comment

Comments

@Sbou
Copy link

Sbou commented Feb 1, 2013

Hi,

For my needs I change the class "ViewDeckController" so that it is inherited.
In the comments, it was indicated that it was sealed for WeakDelegate.
I put all the exported methods protected instead of private and it works for me.

Is there another problem that I have not seen?
@sgmunn
Copy link
Owner

sgmunn commented Feb 2, 2013

You are fine doing that, protected methods are work but don't always make sense from an inheritance point of view - it doesn't really make sense for a subclass to be able to call these method directly, but other than that no problems that I'm aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgmunn @Sbou