Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May make TopDownSet a subclass of SummarizedExperiment #65

Open
sgibb opened this issue Dec 8, 2017 · 1 comment
Open

May make TopDownSet a subclass of SummarizedExperiment #65

sgibb opened this issue Dec 8, 2017 · 1 comment
Assignees
@sgibb
Labels
TODO

Comments

@sgibb
Copy link
Owner

sgibb commented Dec 8, 2017

The implementation of SummarizedExperiment changed recently. Now they support non GRanges rowData. So I have to reevaluated whether it would be good to inherit from SummarizedExperiment.
@sgibb sgibb added the TODO label Dec 8, 2017
@sgibb sgibb self-assigned this Dec 8, 2017
@sgibb
Copy link
Owner Author

sgibb commented Feb 1, 2018

If we ever decide to rewrite the TopDownSet object. We should think about storing the original mz values as well (see #70).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgibb sgibb

Labels
TODO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgibb