Skip to content

New 0.2.x release to fix rustc error #210

Closed
@Mark-Simulacrum

Description

@Mark-Simulacrum

We use the 0.2.29 release in perf.rust-lang.org's html5ever benchmark which currently errors with this error. Can we release a 0.2.30 with a fix? I can try to prepare a PR it would be accepted.

error: macro-expanded `macro_export` macros from the current crate cannot be referred to by absolute paths
  --> /home/alex/.cargo/registry/src/github.com-1ecc6299db9ec823/string_cache-0.2.29/src/lib.rs:71:13
   |
71 |     pub use atom;
   |             ^^^^
   |
note: the macro is defined here
  --> /tmp/.tmpFazpQK/target/debug/build/string_cache-589ae806702507d8/out/atom_macro.rs:2:1
   |
2  | / macro_rules! atom {
3  | | (\"sdev\") => { $crate::Atom { unsafe_data: 0x2 } };
4  | | (\"onstart\") => { $crate::Atom { unsafe_data: 0x100000002 } };
5  | | (\"overflow\") => { $crate::Atom { unsafe_data: 0x200000002 } };
...  |
127| | (\"stroke-miterlimit\") => { $crate::Atom { unsafe_data: 0x4f400000002 } };
127| | }
   | |_^

error: aborting due to previous error

cc rust-lang/rust#53495

Activity

jdm

jdm commented on Aug 20, 2018

@jdm
Member

I would accept and publish a change to fix that.

Mark-Simulacrum

Mark-Simulacrum commented on Aug 21, 2018

@Mark-Simulacrum
Author

@jdm There doesn't seem to be a tag for 0.2.29, is there a chance it's just not been pushed?

jdm

jdm commented on Aug 21, 2018

@jdm
Member

No, we just aren't always great at tagging releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jdm@Mark-Simulacrum

        Issue actions

          New 0.2.x release to fix rustc error · Issue #210 · servo/string-cache