Skip to content

Use track_caller for DomRefCell #27336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdm opened this issue Jul 20, 2020 · 0 comments · Fixed by #33111
Closed

Use track_caller for DomRefCell #27336

jdm opened this issue Jul 20, 2020 · 0 comments · Fixed by #33111
Labels
A-content/script Related to the script thread I-papercut Small but painful.

Comments

@jdm
Copy link
Member

jdm commented Jul 20, 2020

We should apply the same fix as rust-lang/rust#74526 to our RefCell wrapper.
@jdm jdm added I-papercut Small but painful. A-content/script Related to the script thread labels Jul 20, 2020
simonwuelker added a commit to simonwuelker/servo that referenced this issue Aug 18, 2024
@simonwuelker
Annotate DomRefCell::borrow/borrow_mut with #[track_caller]
bf6f359 
Fixes servo#27336

Signed-off-by: Simon Wülker <[email protected]>
@simonwuelker simonwuelker mentioned this issue Aug 18, 2024
Merged
5 tasks
simonwuelker added a commit to simonwuelker/servo that referenced this issue Aug 18, 2024
@simonwuelker
Annotate DomRefCell::borrow/borrow_mut with #[track_caller]
269f05d 
Fixes servo#27336

Signed-off-by: Simon Wülker <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Aug 19, 2024
@simonwuelker
Fix incorrect documentation and add track_caller to DomRefCell meth…
84b5b64 
…ods (#33111)

* Fix DomRefCell documentation about panic behaviour

Fixes #33099

Signed-off-by: Simon Wülker <[email protected]>

* Annotate DomRefCell::borrow/borrow_mut with #[track_caller]

Fixes #27336

Signed-off-by: Simon Wülker <[email protected]>

---------

Signed-off-by: Simon Wülker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script Related to the script thread I-papercut Small but painful.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect documentation and add track_caller to DomRefCell methods simonwuelker/servo
1 participant
@jdm