Workflow routing does not respect `Operator` labels

[cdavernas]

I tried this:

Create a new workflow instance with the synapse.io/operator label, to route it to operator default-operator.default:

{
  ...
  "metadata": {
    ...
    "labels": {
      "synapse.io/operator": "default-operator.default"
    }
  }
  ...
}

This happened:

The workflow instance got picked by a random operator, instead of default-operator.default.

I expected this:

The workflow instance to be execute by default-operator.default.

Is there a workaround?

No.

Anything else?

The bug has been reported by @ericlacher in #511.

Specifically, it is due to the following codelines:

• https://github.com/serverlessworkflow/synapse/blob/main/src/operator/Synapse.Operator/Services/WorkflowInstanceController.cs#L90
• https://github.com/serverlessworkflow/synapse/blob/main/src/operator/Synapse.Operator/Services/WorkflowInstanceController.cs#L115
• https://github.com/serverlessworkflow/synapse/blob/main/src/operator/Synapse.Operator/Services/WorkflowController.cs#L98
• https://github.com/serverlessworkflow/synapse/blob/main/src/operator/Synapse.Operator/Services/WorkflowController.cs#L123

Thank you @ericlacher for reporting an pinpointing the issue!!! ❤️

Platform(s)

No response

Community Notes

• Please vote by adding a 👍 reaction to the issue to help us prioritize.
• If you are interested to work on this issue, please leave a comment.name: Bug Report 🐞

[ericlacher]

@cdavernas I can confirm this now works for me, when setting labels on the workflow instance like so:
POST api/v1/workflow-instances

{
  ...
  "metadata": {
      "labels":
          "synapse.io/operator": "my-operator"
      }
  }
}

What does not work is, setting a selector on the operator like so

spec:
  selector:
    realm: someRealm

then creating instances like this:
POST api/v1/workflow-instances

{
  ...
  "metadata": {
      "labels": {
          "realm": "someRealm"
      }
  }
}

Is this how selector is intended to get used?
What happens is, that in the UI (Workflow instances) I first see one operator being assigned, then after a short while the operator field gets changed to the other. I guess both operators are attempting to execute it, or similar.

[ericlacher]

FYI, I also tried adding the synapse.io/operator label to the workflow (not instance) metadata.labels, this did not work as well.