Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts are not awaited by default #487

Closed
toxik opened this issue Jan 23, 2025 · 1 comment · Fixed by #488
Closed

Scripts are not awaited by default #487

toxik opened this issue Jan 23, 2025 · 1 comment · Fixed by #488
Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: bug Something isn't working weight: 1 An issue that has a very low development impact
Milestone

Comments

@toxik
Copy link
Contributor

toxik commented Jan 23, 2025

I tried this:

The script tasks don't wait until completion

document:
  dsl: 1.0.0-alpha5
  namespace: default
  name: scripts
  version: 0.1.32
do:
- log:
    run:
      script:
        language: js
        code: >
          console.log('hello world'); setTimeout(() => console.log('it waited for a bit!'))
      await: true

This happened:

The script task is fire and forget.

I expected this:

No response

Is there a workaround?

changing to await: false seem to wait for the script to complete

Anything else?

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.name: Bug Report 🐞
@toxik toxik added the type: bug Something isn't working label Jan 23, 2025
toxik added a commit to toxik/synapse that referenced this issue Jan 23, 2025
toxik added a commit to toxik/synapse that referenced this issue Jan 23, 2025
@cdavernas cdavernas added priority: high Indicates a high priority issue weight: 1 An issue that has a very low development impact app: runner Concerns the Runner labels Jan 23, 2025
@cdavernas cdavernas added this to the v1.0.0 milestone Jan 23, 2025
@cdavernas
Copy link
Member

@toxik Thanks for reporting!!!

P.S.: Don't hesitate to star the project in sign of support to the project!

@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Jan 23, 2025
@cdavernas cdavernas linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: bug Something isn't working weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants