Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow entering infinite loop while using wait task #485

Closed
SonaThaj opened this issue Jan 23, 2025 · 2 comments · Fixed by #486
Closed

Flow entering infinite loop while using wait task #485

SonaThaj opened this issue Jan 23, 2025 · 2 comments · Fixed by #486
Assignees
Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: bug Something isn't working weight: 1 An issue that has a very low development impact
Milestone

Comments

@SonaThaj
Copy link

SonaThaj commented Jan 23, 2025

I tried this:

Called 2 wait tasks one after the other with the same wait duration.

This happened:

The workflow entered an infinite loop.

I expected this:

After the second wait task, flow should have proceeded normally, without entering infinite loop.

Is there a workaround?

If the wait duration is not the same, then infinite loop can be avoided. For eg, if the first wait task is waiting for 3s, then the second wait task duration should not be 3s.

Anything else?

Test code:

document:
  dsl: 1.0.0-alpha5
  namespace: default
  name: test-wait
  version: 0.1.4
do:
- dummyset-1:
    set:
      test-1: hello
- wait-1:
    wait:
      seconds: 3
- dummyset-2:
    set:
      test-2: hello
- wait-2:
    wait:
      seconds: 3
- dummyset-3:
    set:
      test-3: hello

Instance:

Image

Platform(s)

Windows

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.name: Bug Report 🐞
@SonaThaj SonaThaj added the type: bug Something isn't working label Jan 23, 2025
@SonaThaj SonaThaj changed the title Entering infinite loop while using wait task Flow entering infinite loop while using wait task Jan 23, 2025
@cdavernas
Copy link
Member

@SonaThaj Fixed with incoming PR! Please do not hesitate to star the project in sign of support!

@cdavernas cdavernas added priority: high Indicates a high priority issue weight: 1 An issue that has a very low development impact app: runner Concerns the Runner labels Jan 23, 2025
@cdavernas cdavernas added this to the v1.0.0 milestone Jan 23, 2025
@cdavernas cdavernas self-assigned this Jan 23, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Jan 23, 2025
@SonaThaj
Copy link
Author

@SonaThaj Fixed with incoming PR! Please do not hesitate to star the project in sign of support!

Thanks for the quick fix! Just starred the project — really appreciate the amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: bug Something isn't working weight: 1 An issue that has a very low development impact
Projects
Status: Done
2 participants