Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Commit eb4cff5

Browse files
wbrezatbarlow12
authored andcommitted
Fixes issue where compile errors are not caught during build steps (#180)
- Fixes missing import statements in MockFactory - Adds new CI step to confirm TypeScript compile succeeds before running tests.
1 parent 0f6242d commit eb4cff5

File tree

4 files changed

+63
-21
lines changed

4 files changed

+63
-21
lines changed

.travis.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,15 @@ install:
2727
jobs:
2828
include:
2929
- stage: test
30-
name: "Unit Tests on Node 8"
30+
name: "Compile & Unit Tests on Node 8"
3131
node_js: "8"
3232
script:
33+
- npm run compile
3334
- npm run test:ci
3435
after_success:
3536
- npm run test:coverage
3637
- cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage
37-
- name: "Unit Tests on Node 10"
38+
- name: "Compile & Unit Tests on Node 10"
3839
node_js: "10"
3940

4041
- stage: publish

package-lock.json

+44-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
"test": "jest",
1515
"test:ci": "npm run test -- --ci",
1616
"test:coverage": "npm run test -- --coverage",
17+
"compile": "tsc",
1718
"prebuild": "shx rm -rf lib/ && npm run test",
18-
"build": "tsc"
19+
"build": "npm run compile"
1920
},
2021
"repository": {
2122
"git": "https://github.com/serverless/serverless-azure-functions"

src/test/mockFactory.ts

+14-7
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,21 @@
1-
import { DeploymentsListByResourceGroupResponse } from "@azure/arm-resources/esm/models";
2-
import { HttpHeaders, HttpOperationResponse, HttpResponse, WebResource } from "@azure/ms-rest-js";
3-
import { LinkedSubscription, TokenCredentialsBase } from "@azure/ms-rest-nodeauth";
4-
import { TokenResponse } from "@azure/ms-rest-nodeauth/dist/lib/credentials/tokenClientCredentials";
5-
import { ServiceListContainersSegmentResponse } from "@azure/storage-blob/typings/lib/generated/lib/models";
6-
import { AxiosResponse } from "axios";
71
import yaml from "js-yaml";
82
import Serverless from "serverless";
93
import Service from "serverless/classes/Service";
104
import Utils from "serverless/classes/Utils";
115
import PluginManager from "serverless/lib/classes/PluginManager";
6+
import { HttpHeaders, HttpOperationResponse, HttpResponse, WebResource } from "@azure/ms-rest-js";
7+
import { LinkedSubscription, TokenCredentialsBase, AuthResponse } from "@azure/ms-rest-nodeauth";
8+
import { TokenResponse, TokenClientCredentials } from "@azure/ms-rest-nodeauth/dist/lib/credentials/tokenClientCredentials";
9+
import { ServiceListContainersSegmentResponse } from "@azure/storage-blob/typings/lib/generated/lib/models";
10+
import { AxiosResponse, AxiosRequestConfig } from "axios";
11+
import { ServerlessAzureConfig } from "../models/serverless";
12+
import { AzureServiceProvider, ServicePrincipalEnvVariables } from "../models/azureProvider"
13+
import { Logger } from "../models/generic";
14+
import { ApiCorsPolicy, ApiManagementConfig } from "../models/apiManagement";
15+
import { DeploymentsListByResourceGroupResponse } from "@azure/arm-resources/esm/models";
16+
import { ArmResourceTemplate } from "../models/armTemplates";
17+
import { FunctionEnvelope, Site } from "@azure/arm-appservice/esm/models";
18+
import { ApiManagementServiceResource, ApiContract } from "@azure/arm-apimanagement/esm/models";
1219

1320
function getAttribute(object: any, prop: string, defaultValue: any): any {
1421
if (object && object[prop]) {
@@ -205,7 +212,7 @@ export class MockFactory {
205212
}
206213

207214
public static createTestAzureBlobItem(id: number = 1, index: number = 1, ext: string = ".zip") {
208-
return {
215+
return {
209216
name: `blob-${id}-${index}${ext}`
210217
}
211218
}

0 commit comments

Comments
 (0)