Skip to content

Commit f980383

Browse files
author
Sergey Komisarchik
committed
NU1605 fix for .net core clients
1 parent addaa41 commit f980383

File tree

10 files changed

+35
-39
lines changed

10 files changed

+35
-39
lines changed

.editorconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ insert_final_newline = true
66
indent_style = space
77
indent_size = 4
88

9-
[*.{csproj,json,config,yml}]
9+
[*.{csproj,json,config,yml,props}]
1010
indent_size = 2
1111

1212
[*.sh]

.gitignore

+3-1
Original file line numberDiff line numberDiff line change
@@ -201,4 +201,6 @@ FakesAssemblies/
201201
project.lock.json
202202

203203
#Test files
204-
*.txt
204+
*.txt
205+
206+
artifacts/

Build.ps1

+5-5
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,18 @@ $suffix = @{ $true = ""; $false = "$($branch.Substring(0, [math]::Min(10,$branch
1515

1616
echo "build: Version suffix is $suffix"
1717

18-
foreach ($src in ls src/*) {
18+
foreach ($src in dir src/*) {
1919
Push-Location $src
2020

2121
echo "build: Packaging project in $src"
2222

23-
& dotnet pack -c Release -o ..\..\artifacts --version-suffix=$suffix --include-source
24-
if ($LASTEXITCODE -ne 0) { exit 1 }
23+
& dotnet pack -c Release -o ..\..\artifacts --version-suffix=$suffix
24+
if ($LASTEXITCODE -ne 0) { exit 1 }
2525

2626
Pop-Location
2727
}
2828

29-
foreach ($test in ls test/*.PerformanceTests) {
29+
foreach ($test in dir test/*.PerformanceTests) {
3030
Push-Location $test
3131

3232
echo "build: Building performance test project in $test"
@@ -37,7 +37,7 @@ foreach ($test in ls test/*.PerformanceTests) {
3737
Pop-Location
3838
}
3939

40-
foreach ($test in ls test/*.Tests) {
40+
foreach ($test in dir test/*.Tests) {
4141
Push-Location $test
4242

4343
echo "build: Testing project in $test"

Directory.Build.props

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<Project>
2+
<PropertyGroup>
3+
<LangVersion>latest</LangVersion>
4+
</PropertyGroup>
5+
6+
<ItemGroup Condition="'$(TargetFramework)' == 'net451' Or '$(TargetFramework)' == 'net452' Or '$(TargetFramework)' == 'net46' Or '$(TargetFramework)' == 'net461'">
7+
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies.$(TargetFramework)" Version="1.0.0" PrivateAssets="all" />
8+
</ItemGroup>
9+
</Project>

appveyor.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ build_script:
77
test: off
88
artifacts:
99
- path: artifacts/Serilog.*.nupkg
10+
- path: artifacts/Serilog.*.snupkg
1011
deploy:
1112
- provider: NuGet
1213
api_key:
@@ -17,7 +18,9 @@ deploy:
1718
- provider: GitHub
1819
auth_token:
1920
secure: p4LpVhBKxGS5WqucHxFQ5c7C8cP74kbNB0Z8k9Oxx/PMaDQ1+ibmoexNqVU5ZlmX
20-
artifact: /Serilog.*\.nupkg/
21+
artifacts:
22+
/Serilog.*\.nupkg/
23+
/Serilog.*\.snupkg/
2124
tag: v$(appveyor_build_version)
2225
on:
2326
branch: master

serilog-settings-configuration.sln

+2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ EndProject
88
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "assets", "assets", "{62D0B904-1D11-4962-A4A8-DE28672AA28B}"
99
ProjectSection(SolutionItems) = preProject
1010
.editorconfig = .editorconfig
11+
.gitignore = .gitignore
1112
appveyor.yml = appveyor.yml
1213
Build.ps1 = Build.ps1
1314
CHANGES.md = CHANGES.md
15+
Directory.Build.props = Directory.Build.props
1416
assets\icon.png = assets\icon.png
1517
LICENSE = LICENSE
1618
README.md = README.md

src/Serilog.Settings.Configuration/Serilog.Settings.Configuration.csproj

+10-3
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,30 @@
1515
<PackageId>Serilog.Settings.Configuration</PackageId>
1616
<PackageTags>serilog;json</PackageTags>
1717
<PackageIcon>icon.png</PackageIcon>
18-
<PackageProjectUrl>https://github.com/serilog/serilog-settings-configuration</PackageProjectUrl>
18+
<PackageProjectUrl>https://serilog.net/</PackageProjectUrl>
1919
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
20-
<RepositoryUrl>https://github.com/serilog/serilog-settings-configuration</RepositoryUrl>
21-
<RepositoryType>git</RepositoryType>
2220
<RootNamespace>Serilog</RootNamespace>
21+
<PublishRepositoryUrl>true</PublishRepositoryUrl>
22+
<EmbedUntrackedSources>true</EmbedUntrackedSources>
23+
<IncludeSymbols>true</IncludeSymbols>
24+
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
2325
</PropertyGroup>
2426

2527
<PropertyGroup Condition="('$(TargetFramework)' == 'net451') Or ('$(TargetFramework)' == 'net461')">
2628
<DefineConstants>$(DefineConstants);PRIVATE_BIN</DefineConstants>
2729
</PropertyGroup>
2830

2931
<ItemGroup>
32+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
3033
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.0.4" />
3134
<PackageReference Include="Serilog" Version="2.6.0" />
3235
<None Include="..\..\assets\icon.png" Pack="true" PackagePath=""/>
3336
</ItemGroup>
3437

38+
<ItemGroup Condition="$(TargetFramework) == 'netstandard2.0'">
39+
<PackageReference Include="Microsoft.NETCore.Targets" Version="3.0.0" />
40+
</ItemGroup>
41+
3542
<ItemGroup Condition="'$(TargetFramework)' == 'net451'">
3643
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="1.1.2" />
3744
</ItemGroup>

test/Serilog.Settings.Configuration.Tests/Serilog.Settings.Configuration.Tests.csproj

+1-6
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
</ItemGroup>
3131

3232
<ItemGroup Condition="'$(TargetFramework)' == 'net452'">
33-
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="1.1.1" />
33+
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="1.1.2" />
3434
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="1.1.2" />
3535
</ItemGroup>
3636

@@ -48,9 +48,4 @@
4848
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
4949
<PackageReference Include="xunit" Version="2.2.0" />
5050
</ItemGroup>
51-
52-
<ItemGroup>
53-
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
54-
</ItemGroup>
55-
5651
</Project>

test/TestDummies/Properties/AssemblyInfo.cs

-18
This file was deleted.

test/TestDummies/TestDummies.csproj

-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77
<AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile>
88
<SignAssembly>true</SignAssembly>
99
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
10-
<PackageId>TestDummies</PackageId>
11-
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
12-
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
13-
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
1410
</PropertyGroup>
1511

1612
<ItemGroup>

0 commit comments

Comments
 (0)