Skip to content

ci: update docker compose and wait for db image #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 5, 2025
Merged

ci: update docker compose and wait for db image #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
53d0b53
change docker-compose to docker compose and use eficode/wait-for inst…
michaelsho-chkp May 5, 2025
a46d444
fix(ci): jwilder/dockerize instead of giorgos/takis
michaelsho-chkp May 5, 2025
9b2b1d7
fix(ci): change hostname to wait for
michaelsho-chkp May 5, 2025
6337efc
test(ci): readd --link
michaelsho-chkp May 5, 2025
8a8c238
fix(ci): revert yarn to main
michaelsho-chkp May 5, 2025
aeafb5d
test(ci): check postgres container name
michaelsho-chkp May 5, 2025
2f5b870
test(ci): check mysql container port
michaelsho-chkp May 5, 2025
82a2f50
fix(ci): use the whole port for postgres
michaelsho-chkp May 5, 2025
1831aca
test(ci): print docker ps
michaelsho-chkp May 5, 2025
0380ba5
test(ci): check the logs of postgres container
michaelsho-chkp May 5, 2025
19b1b35
test(ci): check if the container is still alive
michaelsho-chkp May 5, 2025
c056300
test(ci): check why does the postgres shuts down
michaelsho-chkp May 5, 2025
0f5bd98
fix(ci): fix docker-compose formatting
michaelsho-chkp May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn add sequelize@${{ matrix.sequelize-version }} --ignore-engines
- run: docker-compose up -d ${DIALECT}
- run: docker run --link ${DIALECT}:db -e CHECK_PORT=${SEQ_PORT::-1} -e CHECK_HOST=db --net cli_default giorgos/takis
- run: docker compose up -d ${DIALECT}
- run: docker run --link ${DIALECT}:db --net cli_default jwilder/dockerize -wait tcp://${DIALECT}:${SEQ_PORT::-1} -timeout 2m
- run: yarn test
test-mysql:
strategy:
Expand All @@ -47,8 +47,8 @@ jobs:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --ignore-engines
- run: yarn add sequelize@${{ matrix.sequelize-version }} --ignore-engines
- run: docker-compose up -d ${DIALECT}
- run: docker run --link ${DIALECT}:db -e CHECK_PORT=${SEQ_PORT::-1} -e CHECK_HOST=db --net cli_default giorgos/takis
- run: docker compose up -d ${DIALECT}
- run: docker run --link ${DIALECT}:db --net cli_default jwilder/dockerize -wait tcp://${DIALECT}:${SEQ_PORT::-1} -timeout 2m
- run: yarn test
test-sqlite:
strategy:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ services:
- "54320:5432"
container_name: postgres
command: >
bash -c "sed -i -e 's/# \(zh_TW\|en_US\).UTF-8 UTF-8/\1.UTF-8 UTF-8/' /etc/locale.gen
bash -c "sed -i -e 's/# \\(zh_TW\\|en_US\\).UTF-8 UTF-8/\\1.UTF-8 UTF-8/' /etc/locale.gen
&& locale-gen
&& docker-entrypoint.sh postgres"

Expand Down