Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ssl connection options #3

Open
codepattern opened this issue Oct 26, 2017 · 1 comment
Open

enable ssl connection options #3

codepattern opened this issue Oct 26, 2017 · 1 comment

Comments

@codepattern
Copy link

Hello, thanks for delivering this plugin. I was wondering if there's an option to add the SSL or possibly, more importantly, enabling insecure connections like the check-http.rb.

option :insecure,
short: '-k',
boolean: true,
description: 'Enabling insecure connections',
default: false

Currently, the following error is received when trying to connect locally to a ssl port

Command:
/opt/sensu/embedded/bin/check-jvm-thread-count-pcnt.rb -w 80 -c 90 -u https://localhost:8090/plugins/servlet/jolokia/list

Result:
CheckJvmThreadCountPcnt UNKNOWN: hostname "127.0.0.1" does not match the server certificate

@majormoses
Copy link
Member

Taking a look there is no exposed option in the check. I did a quick scan of the upstream library and while it does not expose it directly it uses faraday under the hood so it should be relatively easy to implement upstream and then add here: https://github.com/towerhe/jolokia/blob/484868f75e6da906fe5cc9c23c6f5bb28fd9af04/lib/jolokia/client.rb#L63-L72. Here is the upstream faraday code: https://github.com/lostisland/faraday/blob/v0.13.1/lib/faraday/options.rb#L216-L226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants