Skip to content

Commit c8d28cb

Browse files
authored
Merge pull request #16 from disktnk/fix/update-ci
Update CI config, remove too old golang version
2 parents b1a0f29 + 2b29425 commit c8d28cb

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

.travis.yml

+6-16
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,14 @@ language: go
22

33
matrix:
44
include:
5-
- go: 1.4.3
5+
- go: 1.9
66
env:
77
- PYTHON_VERSION=2.7
8-
- go: 1.5.4
8+
- go: 1.9
99
env:
10-
- PYTHON_VERSION=2.7
11-
- go: 1.6.4
12-
env:
13-
- CHECK_GOLINT=true
14-
- PYTHON_VERSION=2.7
15-
- go: 1.7.4
16-
env:
17-
- CHECK_GOLINT=true
18-
- PYTHON_VERSION=2.7
19-
- go: 1.7.4
20-
env:
21-
- CHECK_GOLINT=true
22-
- PYTHON_VERSION=3.4
10+
- CHECK_GOLINT=false # tentatively off, golint not support go1.9
11+
- PYTHON_VERSION=3.4 # Ubuntu14's python3 = 3.4.x
12+
- GOCOVERAGE=true
2313

2414
sudo: required
2515
dist: trusty
@@ -67,4 +57,4 @@ script:
6757
fi
6858

6959
after_success:
70-
- if [ "$TRAVIS_GO_VERSION" = "1.7.4" ]; then goveralls -coverprofile=.profile.cov -repotoken $COVERALLS_TOKEN; fi
60+
- if [ $GOCOVERAGE ]; then goveralls -coverprofile=.profile.cov -repotoken=$COVERALLS_TOKEN; fi

module_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ func TestLoadModuleError(t *testing.T) {
1616
_, err := LoadModule("not_exist_module")
1717
Convey("Then an error should be occurred", func() {
1818
So(err, ShouldNotBeNil)
19-
So(err.Error(), ShouldContainSubstring, "ImportError")
19+
// Python2.7,<=3.5: ImportError, >=3.6: ModuleNotFoundError
20+
So(err.Error(), ShouldContainSubstring, "Error")
2021
})
2122
})
2223

0 commit comments

Comments
 (0)