Skip to content

Commit fcf1d4b

Browse files
committed
Set Chrome browser default window size on launch
1 parent 5389c3b commit fcf1d4b

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from selenium import webdriver
66
from selenium.common.exceptions import WebDriverException
77
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
8-
from seleniumbase.config import settings
98
from seleniumbase.config import proxy_list
109
from seleniumbase.core import download_helper
1110
from seleniumbase.fixtures import constants
@@ -73,11 +72,6 @@ def _set_chrome_options(downloads_path, proxy_string):
7372
chrome_options.add_argument("--disable-web-security")
7473
if proxy_string:
7574
chrome_options.add_argument('--proxy-server=%s' % proxy_string)
76-
if settings.START_CHROME_IN_FULL_SCREEN_MODE:
77-
# Run Chrome in full screen mode on WINDOWS
78-
chrome_options.add_argument("--start-maximized")
79-
# Run Chrome in full screen mode on MAC/Linux
80-
chrome_options.add_argument("--kiosk")
8175
if "win32" in sys.platform or "win64" in sys.platform:
8276
chrome_options.add_argument("--log-level=3")
8377
return chrome_options

seleniumbase/fixtures/base_case.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2252,11 +2252,22 @@ def get_new_driver(self, browser=None, headless=None,
22522252
# Make sure the invisible browser window is big enough
22532253
try:
22542254
self.set_window_size(1920, 1200)
2255+
self.wait_for_ready_state_complete()
22552256
except Exception:
22562257
# This shouldn't fail, but in case it does,
22572258
# get safely through setUp() so that
22582259
# WebDrivers can get closed during tearDown().
22592260
pass
2261+
else:
2262+
if self.browser == 'chrome':
2263+
try:
2264+
if settings.START_CHROME_IN_FULL_SCREEN_MODE:
2265+
self.driver.maximize_window()
2266+
else:
2267+
self.driver.set_window_size(1250, 800)
2268+
self.wait_for_ready_state_complete()
2269+
except Exception:
2270+
pass # Keep existing browser resolution
22602271
return new_driver
22612272

22622273
def switch_to_driver(self, driver):

0 commit comments

Comments
 (0)