Skip to content

Commit f10ca20

Browse files
committed
Update methods
1 parent 0fa2fe3 commit f10ca20

File tree

4 files changed

+25
-2
lines changed

4 files changed

+25
-2
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,8 @@ def extend_driver(driver):
203203
driver.is_exact_text_visible = DM.is_exact_text_visible
204204
driver.is_attribute_present = DM.is_attribute_present
205205
driver.is_non_empty_text_visible = DM.is_non_empty_text_visible
206+
driver.is_valid_url = DM.is_valid_url
207+
driver.is_alert_present = DM.is_alert_present
206208
driver.is_online = DM.is_online
207209
driver.js_click = DM.js_click
208210
driver.get_text = DM.get_text

seleniumbase/core/sb_driver.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,17 @@ def is_non_empty_text_visible(self, *args, **kwargs):
161161
self.driver, *args, **kwargs
162162
)
163163

164+
def is_valid_url(self, url):
165+
"""Return True if the url is a valid url."""
166+
return page_utils.is_valid_url(url)
167+
168+
def is_alert_present(self):
169+
try:
170+
self.driver.switch_to.alert
171+
return True
172+
except Exception:
173+
return False
174+
164175
def is_online(self):
165176
return self.driver.execute_script("return navigator.onLine;")
166177

seleniumbase/fixtures/base_case.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7813,6 +7813,13 @@ def is_valid_url(self, url):
78137813
"""Return True if the url is a valid url."""
78147814
return page_utils.is_valid_url(url)
78157815

7816+
def is_alert_present(self):
7817+
try:
7818+
self.driver.switch_to.alert
7819+
return True
7820+
except Exception:
7821+
return False
7822+
78167823
def is_online(self):
78177824
"""Return True if connected to the Internet."""
78187825
return self.execute_script("return navigator.onLine;")

seleniumbase/fixtures/page_utils.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,15 @@ def is_valid_url(url):
163163
r"(?:/?|[/?]\S+)$",
164164
re.IGNORECASE,
165165
)
166-
return (
166+
if (
167167
regex.match(url)
168168
or url.startswith((
169169
"about:", "blob:", "chrome:", "data:", "edge:", "file:"
170170
))
171-
)
171+
):
172+
return True
173+
else:
174+
return False
172175

173176

174177
def _get_unique_links(page_url, soup):

0 commit comments

Comments
 (0)