Skip to content

Commit e5d594b

Browse files
authored
Merge pull request #285 from seleniumbase/update-webdriver-installation-script
Update webdriver installation script
2 parents 968701b + 17f4de9 commit e5d594b

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

seleniumbase/config/settings.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@
5353
'''
5454
WAIT_FOR_ANGULARJS = True
5555

56-
# Option to start Chrome in full screen mode by default
57-
START_CHROME_IN_FULL_SCREEN_MODE = False
58-
5956
# Default time to wait after each browser action performed during Demo Mode.
6057
# Use Demo Mode when you want others to see what your automation is doing.
6158
# Usage: "--demo_mode". (Can be overwritten by using "--demo_sleep=TIME".)

seleniumbase/console_scripts/sb_install.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,17 @@ def main():
7171
inner_folder = None
7272

7373
if name == "chromedriver":
74+
latest_version = "2.46"
7475
if "darwin" in sys_plat:
7576
file_name = "chromedriver_mac64.zip"
7677
elif "linux" in sys_plat:
78+
latest_version = "2.40" # Linux machines may need the old driver
7779
file_name = "chromedriver_linux64.zip"
7880
elif "win32" in sys_plat or "win64" in sys_plat or "x64" in sys_plat:
7981
file_name = "chromedriver_win32.zip" # Works for win32 / win_x64
8082
else:
8183
raise Exception("Cannot determine which version of Chromedriver "
8284
"to download!")
83-
latest_version = "2.40"
8485
download_url = ("http://chromedriver.storage.googleapis.com/"
8586
"%s/%s" % (latest_version, file_name))
8687
# Forcing Chromedriver v2.40 for now, even though it's not the latest.
@@ -98,7 +99,7 @@ def main():
9899
"%s/%s" % (latest_version, file_name))
99100
print("Found %s" % download_url)
100101
elif name == "geckodriver" or name == "firefoxdriver":
101-
latest_version = "v0.23.0"
102+
latest_version = "v0.24.0"
102103
if "darwin" in sys_plat:
103104
file_name = "geckodriver-%s-macos.tar.gz" % latest_version
104105
elif "linux" in sys_plat:
@@ -140,7 +141,7 @@ def main():
140141
"%s/%s" % (major_version, file_name))
141142
elif name == "operadriver" or name == "operachromiumdriver":
142143
name = "operadriver"
143-
latest_version = "v.2.37"
144+
latest_version = "v.2.40"
144145
if "darwin" in sys_plat:
145146
file_name = "operadriver_mac64.zip"
146147
platform_code = "mac64"

seleniumbase/fixtures/base_case.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2428,12 +2428,15 @@ def get_new_driver(self, browser=None, headless=None,
24282428
# WebDrivers can get closed during tearDown().
24292429
pass
24302430
else:
2431-
if self.browser == 'chrome':
2431+
if self.browser == 'chrome' or self.browser == 'opera':
24322432
try:
2433-
if settings.START_CHROME_IN_FULL_SCREEN_MODE:
2434-
self.driver.maximize_window()
2435-
else:
2436-
self.driver.set_window_size(1250, 840)
2433+
self.driver.set_window_size(1250, 840)
2434+
self.wait_for_ready_state_complete()
2435+
except Exception:
2436+
pass # Keep existing browser resolution
2437+
elif self.browser == 'edge':
2438+
try:
2439+
self.driver.maximize_window()
24372440
self.wait_for_ready_state_complete()
24382441
except Exception:
24392442
pass # Keep existing browser resolution

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
setup(
1919
name='seleniumbase',
20-
version='1.19.8',
20+
version='1.19.9',
2121
description='Reliable Browser Automation & Testing Framework',
2222
long_description=long_description,
2323
long_description_content_type='text/markdown',

0 commit comments

Comments
 (0)