Skip to content

Commit bf968cd

Browse files
authored
Merge pull request #222 from seleniumbase/requirements-update
Removing "urllib3" requirement to prevent conflicts with "requests"
2 parents 37cc758 + fcff4e6 commit bf968cd

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ requests>=2.19.1
1515
unittest2>=1.1.0
1616
chardet>=3.0.4
1717
boto>=2.49.0
18-
urllib3==1.23
1918
nose==1.3.7
2019
ipdb==0.11
2120
flake8==3.5.0

seleniumbase/console_scripts/sb_install.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@
1919
import shutil
2020
import sys
2121
import tarfile
22-
import urllib3
2322
import zipfile
2423
from seleniumbase import drivers # webdriver storage folder for SeleniumBase
25-
urllib3.disable_warnings()
24+
requests.packages.urllib3.disable_warnings()
2625
DRIVER_DIR = os.path.dirname(os.path.realpath(drivers.__file__))
2726

2827

@@ -188,7 +187,7 @@ def main():
188187
if not os.path.exists(downloads_folder):
189188
os.mkdir(downloads_folder)
190189
local_file = open(file_path, 'wb')
191-
http = urllib3.PoolManager()
190+
http = requests.packages.urllib3.PoolManager()
192191
remote_file = http.request('GET', download_url, preload_content=False)
193192
print('\nDownloading %s from:\n%s ...' % (file_name, download_url))
194193
local_file.write(remote_file.read())

seleniumbase/core/browser_launcher.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ def _set_chrome_options(
104104
chrome_options, proxy_string, proxy_user, proxy_pass)
105105
chrome_options.add_extension(DRIVER_DIR + "/proxy.zip")
106106
chrome_options.add_argument('--proxy-server=%s' % proxy_string)
107-
if "win32" in sys.platform or "win64" in sys.platform:
108-
chrome_options.add_argument("--log-level=3")
109107
return chrome_options
110108

111109

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
setup(
1919
name='seleniumbase',
20-
version='1.16.6',
20+
version='1.16.7',
2121
description='All-In-One Test Automation Framework',
2222
long_description=long_description,
2323
long_description_content_type='text/markdown',
@@ -67,7 +67,6 @@
6767
'unittest2>=1.1.0',
6868
'chardet>=3.0.4',
6969
'boto>=2.49.0',
70-
'urllib3==1.23', # Keep at ==1.23
7170
'nose==1.3.7', # Keep at ==1.3.7
7271
'ipdb==0.11',
7372
'flake8==3.5.0',

0 commit comments

Comments
 (0)