Skip to content

Commit b64cbd8

Browse files
committed
Fix methods for switching drivers in CDP Mode
1 parent a2a6e99 commit b64cbd8

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,7 @@ def uc_open_with_cdp_mode(driver, url=None):
749749
core_items.browser = cdp.browser
750750
core_items.tab = cdp.tab
751751
core_items.util = cdp.util
752+
cdp._swap_driver = CDPM._swap_driver
752753
cdp.core = core_items
753754
cdp.loop = cdp.get_event_loop()
754755
driver.cdp = cdp

seleniumbase/core/sb_cdp.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ def __init__(self, loop, page, driver):
1919
self.page = page
2020
self.driver = driver
2121

22+
def _swap_driver(self, driver):
23+
self.driver = driver
24+
self.page = driver.cdp.page
25+
self.loop = driver.cdp.loop
26+
2227
def __slow_mode_pause_if_set(self):
2328
if (
2429
(hasattr(sb_config, "demo_mode") and sb_config.demo_mode)

seleniumbase/fixtures/base_case.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4358,6 +4358,8 @@ def switch_to_driver(self, driver):
43584358
self.driver = driver
43594359
if self.driver in self._drivers_browser_map:
43604360
self.browser = self._drivers_browser_map[self.driver]
4361+
if self.__is_cdp_swap_needed():
4362+
self.cdp._swap_driver(self.driver)
43614363
self.bring_active_window_to_front()
43624364

43634365
def switch_to_default_driver(self):
@@ -4366,6 +4368,8 @@ def switch_to_default_driver(self):
43664368
self.driver = self._default_driver
43674369
if self.driver in self._drivers_browser_map:
43684370
self.browser = self._drivers_browser_map[self.driver]
4371+
if self.__is_cdp_swap_needed():
4372+
self.cdp._swap_driver(self.driver)
43694373
self.bring_active_window_to_front()
43704374

43714375
def save_screenshot(

0 commit comments

Comments
 (0)