Skip to content

Commit 0625f2d

Browse files
committed
Update comments
1 parent 9e8552e commit 0625f2d

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

seleniumbase/config/proxy_list.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
"pytest SOME_TEST.py --proxy=proxy1"
99
1010
Format of PROXY_LIST server entries:
11-
* "ip_address:port"
11+
* "ip_address:port" OR
12+
* "server:port"
13+
(Do NOT include the http:// or https:// in your proxy string!)
1214
1315
Example proxies in PROXY_LIST below are not guaranteed to be active or secure.
1416
If you don't already have a proxy server to connect to,

seleniumbase/plugins/pytest_plugin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def pytest_addoption(parser):
8888
dest='headless',
8989
default=False,
9090
help="""Using this makes Webdriver run headlessly,
91-
which is useful inside a Linux Docker.""")
91+
which is required on headless machines.""")
9292
parser.addoption('--is_pytest', action="store_true",
9393
dest='is_pytest',
9494
default=True,

seleniumbase/plugins/selenium_plugin.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@ class SeleniumBrowser(Plugin):
1717
self.options.browser -- the browser to use (--browser)
1818
self.options.server -- the server used by the test (--server)
1919
self.options.port -- the port used by the test (--port)
20+
self.options.proxy -- designates the proxy server:port to use. (--proxy)
2021
self.options.headless -- the option to run headlessly (--headless)
2122
self.options.demo_mode -- the option to slow down Selenium (--demo_mode)
2223
self.options.demo_sleep -- Selenium action delay in DemoMode (--demo_sleep)
2324
self.options.highlights -- # of highlight animations shown (--highlights)
25+
self.options.ad_block -- the option to block some display ads (--ad_block)
2426
self.options.verify_delay -- delay before MasterQA checks (--verify_delay)
2527
self.options.timeout_multiplier -- increase defaults (--timeout_multiplier)
2628
"""
@@ -66,7 +68,7 @@ def options(self, parser, env):
6668
dest='headless',
6769
default=False,
6870
help="""Using this makes Webdriver run headlessly,
69-
which is useful inside a Linux Docker.""")
71+
which is required on headless machines.""")
7072
parser.add_option(
7173
'--demo_mode', action="store_true",
7274
dest='demo_mode',
@@ -109,9 +111,6 @@ def configure(self, options, conf):
109111
self.headless_active = False # Default setting
110112

111113
def beforeTest(self, test):
112-
""" Running Selenium locally will be handled differently
113-
from how Selenium is run remotely, such as from Jenkins. """
114-
115114
test.test.browser = self.options.browser
116115
test.test.headless = self.options.headless
117116
test.test.servername = self.options.servername

0 commit comments

Comments
 (0)