Merge branch 'develop' into jfoskin-patch-2

Author: forstisabella

.github/styles/Vocab/Docs/accept.txt

@@ -22,6 +22,7 @@ Aampe
 adset
 Adwords
 Aircall
+Airdat(?:e|es)
 Algolia
 allowlist
 Amberflo
@@ -38,17 +39,21 @@ blocklist
 Bluedot
 bool
 boolean
+Braze's
 Breyta
 Chargebee
 chatbot
 cli
 CloudFront
 Cocoapods
+comScore
 Contentful
+Cordova
 Criteo
 csv
 Databricks
 datetime
+debouncing
 deeplink
 Dev
 Doubleclick
@@ -99,6 +104,7 @@ Marketo
 Matcha
 matchers
 measurability
+Metrix
 middleware
 Middleware
 Mixpanel
@@ -122,6 +128,7 @@ performant
 Pinterest
 Pipedrive
 Preact
+Proguard
 Qualtrics
 reformat(:?s)
 remarket

CODEOWNERS

@@ -25,48 +25,26 @@ CODEOWNERS  @segmentio/segment-doc-team
 
 
 # Destinations owners
-/src/connections/destinations  @stayseesong @markzegarelli
+# /src/connections/destinations  @stayseesong @markzegarelli
 
 # Stratconn
 ## Adobe
-/src/connections/destinations/catalog/adobe-analytics/ @kdaswani
-/src/connections/destinations/catalog/actions-adobe-target-web/ @kdaswani
-/src/connections/destinations/catalog/actions-adobe-target-cloud/ @kdaswani
-/src/connections/destinations/catalog/marketo-v2/ @kdaswani
-/src/connections/destinations/catalog/marketo-static-lists/ @kdaswani
+
 
 ## Facebook
-/src/connections/destinations/catalog/facebook-pixel/ @kdaswani
-/src/connections/destinations/catalog/actions-facebook-conversions-api/ @kdaswani
-/src/connections/destinations/catalog/facebook-app-events/ @kdaswani
-/src/connections/destinations/catalog/facebook-offline-conversions/ @kdaswani
-/src/connections/destinations/catalog/personas-facebook-custom-audiences/ @kdaswani
+
 
 ## Google
-/src/connections/destinations/catalog/firebase/ @kdaswani
-/src/connections/destinations/catalog/google-analytics/ @kdaswani
-/src/connections/destinations/catalog/actions-google-analytics-4/ @kdaswani
-/src/connections/destinations/catalog/google-tag-manager/ @kdaswani
-/src/connections/destinations/catalog/actions-google-enhanced-conversions/ @kdaswani
-/src/connections/destinations/catalog/doubleclick-floodlight/ @kdaswani
-/src/connections/destinations/catalog/google-ads-classic/ @kdaswani
-/src/connections/destinations/catalog/google-ads-gtag/ @kdaswani
-/src/connections/destinations/catalog/google-cloud-function/ @kdaswani
-/src/connections/destinations/catalog/google-cloud-pubsub/ @kdaswani
-/src/connections/destinations/catalog/adwords-remarketing-lists/ @kdaswani
-/src/connections/destinations/catalog/personas-display-video-360/ @kdaswani
+
 
 ## Salesforce
-/src/connections/destinations/catalog/salesforce/ @kdaswani
-/src/connections/destinations/catalog/actions-salesforce/ @kdaswani
-/src/connections/destinations/catalog/salesforce-marketing-cloud/ @kdaswani
-/src/connections/destinations/catalog/pardot/ @kdaswani
+
 
 # Engage
 /src/engage/ @markzegarelli @pwseg @rchinn-segment
 
-# Personas owners 
-/src/personas @pwseg @rchinn-segent
+# Unify
+/src/unify @rchinn-segment
 
 # Protocols owners
 /src/protocols @forstisabella

scripts/catalog_papi.js

@@ -15,7 +15,7 @@ const regionalSupport = yaml.load(fs.readFileSync(path.resolve(__dirname, `../sr
 const slugOverrides = yaml.load(fs.readFileSync(path.resolve(__dirname, `../src/_data/catalog/slugs.yml`)))
 
 
-const slugify = (displayName) => {
+const slugify = (displayName, type) => {
   let slug = displayName
     .toLowerCase()
     .replace(/\s+/g, '-')
@@ -24,16 +24,24 @@ const slugify = (displayName) => {
     .replace(/[\(\)]/g, '')
     .replace('.', '-')
 
-  for (key in slugOverrides) {
-    let original = slugOverrides[key].original
-    let override = slugOverrides[key].override
+  let overrides = ""
+  if (type == "sources") {
+    overrides = slugOverrides.sources
+  } 
+
+  if (type == "destinations") {
+    overrides = slugOverrides.destinations
+  } 
+
+  for (key in overrides) {
+    let original = overrides[key].original
+    let override = overrides[key].override
 
     if (slug == original) {
       console.log(original + " -> " + override)
       slug = override
     }
   }
-
   return slug
 }
 
@@ -120,7 +128,7 @@ const getConnectionModes = (destination) => {
       connectionModes.cloud.server = true
     }
   }
- 
+
   return connectionModes
 }
 
@@ -208,7 +216,7 @@ const updateSources = async () => {
   const regionalSourceRegion = regionalSupport.sources.region
 
   sources.forEach(source => {
-    let slug = slugify(source.name)
+    let slug = slugify(source.name, "sources")
     let settings = source.options
     let hidden = false
     let regions = ['us']
@@ -274,6 +282,7 @@ const updateSources = async () => {
     let updatedRegional = {
       id: source.id,
       display_name: source.name,
+      hidden: isCatalogItemHidden(url),
       slug,
       url,
       regions,
@@ -361,14 +370,14 @@ const updateDestinations = async () => {
     let endpoints = []
     let regions = []
 
-    let slug = slugify(destination.name)
-    
+    let slug = slugify(destination.name, "destinations")
+
     if (typeof destination.supportedRegions != "undefined") {
       regions = destination.supportedRegions
     } else {
-      regions.push('us-west-2','eu-west-1')
+      regions.push('us-west-2', 'eu-west-1')
     }
-    if (typeof destination.regionEndpoints != "undefined"){
+    if (typeof destination.regionEndpoints != "undefined") {
       endpoints = destination.regionEndpoints
     } else {
       endpoints.push('US')
@@ -417,7 +426,7 @@ const updateDestinations = async () => {
       return clonedObj;
     };
 
-    
+
     // Force screen method into supportedMethods object
     destination.supportedMethods.screen = false
     // Set it true for LiveLike, per request

scripts/private-destination.js

@@ -47,7 +47,7 @@ const getCatalog = async (url, page_token = "MA==") => {
   }
 }
 
-const slugify = (displayName) => {
+const slugify = (displayName, type) => {
   let slug = displayName
     .toLowerCase()
     .replace(/\s+/g, '-')
@@ -56,15 +56,24 @@ const slugify = (displayName) => {
     .replace(/[\(\)]/g, '')
     .replace('.', '-')
 
-  for (key in slugOverrides) {
-    let original = slugOverrides[key].original
-    let override = slugOverrides[key].override
+  let overrides = ""
+  if (type == "sources") {
+    overrides = slugOverrides.sources
+  } 
+
+  if (type == "destinations") {
+    overrides = slugOverrides.destinations
+  } 
+
+  for (key in overrides) {
+    let original = overrides[key].original
+    let override = overrides[key].override
 
     if (slug == original) {
+      console.log(original + " -> " + override)
       slug = override
     }
   }
-
   return slug
 }
 
@@ -111,7 +120,7 @@ const getDestinationData = async (id) => {
   })
   let actions = destination.actions
   let presets = destination.presets
-  let slug = slugify(destination.name)
+  let slug = slugify(destination.name, "destinations")
   let url = `connections/destinations/catalog/${slug}`
 
   // Force screen method into supportedMethods object
@@ -137,7 +146,7 @@ const getDestinationData = async (id) => {
     id: destination.id,
     display_name: destination.name,
     name: destination.name,
-    slug: slugify(destination.name),
+    slug: slugify(destination.name, "destinations"),
     previous_names: destination.previousNames,
     url,
     website: destination.website,
@@ -194,7 +203,7 @@ const checkExistingStatus = async () => {
     let id = existingIds[i]
     let destination = await checkDestinationStatus(id)
     let status = destination.status
-    let slug = slugify(destination.name)
+    let slug = slugify(destination.name, "destinations")
     let url = `connections/destinations/catalog/${slug}`
 
 

src/_data/catalog/destination_categories.yml

@@ -1,5 +1,5 @@
 # AUTOGENERATED FROM PUBLIC API. DO NOT EDIT
-# destination categories last updated 2023-04-13 
+# destination categories last updated 2023-05-09 
 items:
 - display_name: A/B Testing
   slug: a-b-testing