Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Commit 0644fe2

Browse files
Julio Farahsanscontext
andauthored
Introduce types to ajs core (#166)
* introduce types.ts * update PR template * update codeowners * copy edits Co-authored-by: sanscontext <[email protected]>
1 parent 7c85af7 commit 0644fe2

File tree

7 files changed

+223
-104
lines changed

7 files changed

+223
-104
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @segmentio/libraries-team
1+
@segmentio/libraries-web-team

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 33 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,48 @@
1-
# 🎉 Thanks for taking the time to contribute to Analytics.js! 🎉
1+
## Description
22

3-
It is highly appreciated that you take the time to help improve Analytics.js.
4-
We appreciate it if you would take the time to document your Pull Request.
3+
<!-- # 🎉 Thanks for contributing to Analytics.js! We really appreciate your time. 🎉
54
6-
Sadly, if we don't receive enough information, or the Pull Request doesn't
7-
align well with our roadmap, we might respectfully thank you for your time, and close the issue.
5+
To help us quickly assess your work, please document your Pull Request using this template.
6+
7+
Sadly, we can't merge all PRs - but you can multiply the chances of your change getting in by giving us the information we need. If the Pull Request doesn't align well with our roadmap, we might respectfully thank you for your time, and close the issue. -->
8+
9+
## Test plan
10+
11+
<!-- Provide all possible documentation: screenshots, sh commands, etc.
12+
For change control purposes, use the following pattern:
13+
14+
- Testing completed successfully using <how did you test, environment>; or
15+
- Testing not required because <explain why you think testing isn't needed>
16+
-->
17+
18+
## Release plan
19+
20+
<!-- Update the HISTORY.md file if we need to generate a new version of AJS for your changes.
21+
22+
If not, just add the following line with an explanation:
23+
Release not necessary because <verbose explantaion - for example 'it's a dev-only change'>.
24+
-->
825

926
## Checklist
1027

11-
Please ensure the following are completed to help get your PR merged:
28+
<!--
29+
Make sure you complete the following checklist to help get your PR merged:-->
30+
1231

1332
- [ ] Thorough explanation of the issue/solution, and a link to the related issue
1433
- [ ] CI tests are passing
1534
- [ ] Unit tests were written for any new code
1635
- [ ] Code coverage is at least maintained, or increased.
1736

37+
<!--
1838
## Respect earns Respect 👏
1939
2040
Please respect our Code of Conduct, in short:
2141
22-
- Using welcoming and inclusive language.
23-
- Being respectful of differing viewpoints and experiences.
24-
- Gracefully accepting constructive criticism.
25-
- Focusing on what is best for the community.
26-
- Showing empathy towards other community members.
42+
- Use welcoming and inclusive language.
43+
- Be respectful of differing viewpoints and experiences.
44+
- Gracefully accept constructive criticism.
45+
- Focus on what is best for the community.
46+
- Show empathy toward other community members.
47+
48+
-->

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ install:
4747

4848
# Build typescript
4949
build: clean install
50-
yarn tsc
50+
yarn tsc --declaration
5151
.PHONY: build
5252

5353
# Remove temporary files and build artifacts.

0 commit comments

Comments
 (0)