Skip to content

Commit b456486

Browse files
author
David Pal
committed
Remove python 2 support
1 parent dda5df5 commit b456486

File tree

14 files changed

+22
-38
lines changed

14 files changed

+22
-38
lines changed

.buildscripts/e2e.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,3 @@ else
1212
./tester_linux_amd64 -segment-write-key="${SEGMENT_WRITE_KEY}" -webhook-auth-username="${WEBHOOK_AUTH_USERNAME}" -webhook-bucket="${WEBHOOK_BUCKET}" -path='./e2e_test.sh'
1313
echo "End to end tests completed!"
1414
fi
15-
16-

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ jobs:
2424
steps:
2525
- checkout
2626
- attach_workspace: { at: . }
27-
- run: pip3 install dephell
28-
- run: pip3 install --user appdirs
27+
- run: pip3 install dephell
28+
- run: pip3 install --user appdirs
2929
- run: dephell deps convert --from=setup.py --to=requirements.txt
3030
- run: pip3 install --user -r requirements.txt
3131
- run: curl -sL https://raw.githubusercontent.com/segmentio/snyk_helpers/master/initialization/snyk.sh | sh
@@ -114,7 +114,7 @@ workflows:
114114
- master
115115
- scheduled_e2e_testing
116116
jobs:
117-
- test_36
117+
- test_36
118118
- test_37
119119
- test_38
120-
- test_39
120+
- test_39

.pylintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ init-import=no
306306

307307
# List of qualified module names which can have objects that can redefine
308308
# builtins.
309-
redefining-builtins-modules=six.moves,past.builtins,future.builtins,io,builtins
309+
redefining-builtins-modules=past.builtins,future.builtins,io,builtins
310310

311311

312312
[FORMAT]

HISTORY.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 2.2.0 / 2022-03-07
2+
- Remove Python 2 support
3+
- Remove six package
4+
15
# 2.1.0 / 2022-03-04
26

37
- Raise exception on large message

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
install_dev:
2+
pip install --edit .[dev]
3+
14
test:
25
pylint --rcfile=.pylintrc --reports=y --exit-zero analytics | tee pylint.out
36
flake8 --max-complexity=10 --statistics analytics > flake8.out || true

analytics/consumer.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@
77

88
from analytics.request import post, APIError, DatetimeSerializer
99

10-
try:
11-
from queue import Empty
12-
except ImportError:
13-
from Queue import Empty
10+
from queue import Empty
1411

1512
MAX_MSG_SIZE = 32 << 10
1613

analytics/test/client.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from datetime import date, datetime
22
import unittest
33
import time
4-
import six
54
import mock
65

76
from analytics.version import VERSION

segment/analytics/client.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,15 @@
66
import json
77

88
from dateutil.tz import tzutc
9-
from six import string_types
109

1110
from segment.analytics.utils import guess_timezone, clean
1211
from segment.analytics.consumer import Consumer, MAX_MSG_SIZE
1312
from segment.analytics.request import post, DatetimeSerializer
1413
from segment.analytics.version import VERSION
1514

16-
try:
17-
import queue
18-
except ImportError:
19-
import Queue as queue
15+
import queue
2016

21-
22-
ID_TYPES = (numbers.Number, string_types)
17+
ID_TYPES = (numbers.Number, str)
2318

2419

2520
class Client(object):

segment/analytics/consumer.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,7 @@
66

77
from segment.analytics.request import post, APIError, DatetimeSerializer
88

9-
try:
10-
from queue import Empty
11-
except ImportError:
12-
from Queue import Empty
9+
from queue import Empty
1310

1411
MAX_MSG_SIZE = 32 << 10
1512

segment/analytics/test/client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from datetime import date, datetime
22
import unittest
33
import time
4-
import six
54
import mock
65

76
from analytics.version import VERSION
@@ -286,7 +285,7 @@ def test_success_on_invalid_write_key(self):
286285
self.assertFalse(self.failed)
287286

288287
def test_unicode(self):
289-
Client(six.u('unicode_key'))
288+
Client('unicode_key')
290289

291290
def test_numeric_user_id(self):
292291
self.client.track(1234, 'python event')

0 commit comments

Comments
 (0)