fix update method not called with await (#95)

wenxi-zeng · web-flow · commit e92ab7cb3520 · 2024-03-04T15:15:01.000-06:00
Co-authored-by: Wenxi Zeng &lt;wzeng@twilio.com&gt;
diff --git a/Analytics-CSharp/Segment/Analytics/Settings.cs b/Analytics-CSharp/Segment/Analytics/Settings.cs
@@ -16,7 +16,7 @@ public struct Settings
 
     public partial class Analytics
     {
-        internal async void Update(Settings settings) {
+        internal async Task Update(Settings settings) {
             System systemState = await Store.CurrentState<System>();
             HashSet<int> initializedPlugins = new HashSet<int>();
             Timeline.Apply(plugin => {
@@ -49,7 +49,7 @@ await Scope.WithContext(NetworkIODispatcher, async () =>
                 settings = systemState._settings;
             }
 
-            Update(settings.Value);
+            await Update(settings.Value);
             await Store.Dispatch<System.ToggleRunningAction, System>(new System.ToggleRunningAction(true));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public struct Settings`
`16`	`16`
`17`	`17`	`public partial class Analytics`
`18`	`18`	`{`
`19`		`- internal async void Update(Settings settings) {`
	`19`	`+ internal async Task Update(Settings settings) {`
`20`	`20`	`System systemState = await Store.CurrentState<System>();`
`21`	`21`	`HashSet<int> initializedPlugins = new HashSet<int>();`
`22`	`22`	`Timeline.Apply(plugin => {`
`@@ -49,7 +49,7 @@ await Scope.WithContext(NetworkIODispatcher, async () =>`
`49`	`49`	`settings = systemState._settings;`
`50`	`50`	`}`
`51`	`51`
`52`		`- Update(settings.Value);`
	`52`	`+ await Update(settings.Value);`
`53`	`53`	`await Store.Dispatch<System.ToggleRunningAction, System>(new System.ToggleRunningAction(true));`
`54`	`54`	`}`
`55`	`55`	`}`