fix identify right after init no effect (#19)

* fix identify right after init has no effect

* make startup queue thread safe

* add console sample

* update coroutine version

Author: wenxi-zeng

Analytics-CSharp.sln

@@ -13,6 +13,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "XamarinSample.Droid", "Samp
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "XamarinSample.iOS", "Samples\XamarinSample\XamarinSample.iOS\XamarinSample.iOS.csproj", "{39FCFC71-411C-419E-97BB-7C4281764B10}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ConsoleSample", "Samples\ConsoleSample\ConsoleSample.csproj", "{51261FC5-F6E0-478C-A466-A026A6CFC972}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -36,6 +38,9 @@ Global
 		{39FCFC71-411C-419E-97BB-7C4281764B10}.Release|Any CPU.ActiveCfg = Release|iPhoneSimulator
 		{39FCFC71-411C-419E-97BB-7C4281764B10}.Release|Any CPU.Build.0 = Release|iPhoneSimulator
 		{39FCFC71-411C-419E-97BB-7C4281764B10}.Debug|Any CPU.ActiveCfg = Debug|iPhoneSimulator
+		{51261FC5-F6E0-478C-A466-A026A6CFC972}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{51261FC5-F6E0-478C-A466-A026A6CFC972}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{51261FC5-F6E0-478C-A466-A026A6CFC972}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

Analytics-CSharp/Analytics-CSharp.csproj

@@ -38,7 +38,7 @@
     <Folder Include="Segment\Analytics\Utilities\" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Coroutine.NET" Version="1.0.0" />
+    <PackageReference Include="Coroutine.NET" Version="1.0.1" />
     <PackageReference Include="Serialization.NET" Version="1.0.0" />
     <PackageReference Include="Sovran.NET" Version="1.0.0" />
   </ItemGroup>

Analytics-CSharp/Segment/Analytics/Analytics.cs

@@ -241,12 +241,22 @@ private void Startup(HTTPClient httpClient = null)
             Add(new StartupQueue());
             Add(new ContextPlugin());
 
+            // use Wait() for this coroutine to force completion,
+            // since Store must be setup before any event call happened.
+            // Note: Task.Wait() forces internal async methods to run in a synchronized way,
+            // we should avoid of doing it whenever possible.
             analyticsScope.Launch(analyticsDispatcher, async () =>
             {
                 await store.Provide(UserInfo.DefaultState(configuration, storage));
                 await store.Provide(System.DefaultState(configuration, storage));
                 await storage.SubscribeToStore();
-
+            }).Wait();
+            
+            // check settings over the network,
+            // we don't have to Wait() here, because events are piped in
+            // StartupQueue until settings is ready
+            analyticsScope.Launch(analyticsDispatcher, async () =>
+            {
                 if (configuration.autoAddSegmentDestination)
                 {
                     Add(new SegmentDestination());

Analytics-CSharp/Segment/Analytics/Plugins/StartupQueue.cs

@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Concurrent;
 using Segment.Concurrent;
 using Segment.Sovran;
 
@@ -13,7 +13,7 @@ public class StartupQueue: Plugin, ISubscriber
     {
         private static int maxSize = 1000;
         private readonly AtomicBool _running = new AtomicBool(false);
-        private readonly Queue<RawEvent> _queuedEvents = new Queue<RawEvent>();
+        private readonly ConcurrentQueue<RawEvent> _queuedEvents = new ConcurrentQueue<RawEvent>();
 
         public override PluginType type => PluginType.Before;
 
@@ -34,7 +34,7 @@ public override RawEvent Execute(RawEvent incomingEvent)
                 if (_queuedEvents.Count >= maxSize)
                 {
                     // We've exceeded the max size and need to start dropping events
-                    _queuedEvents.Dequeue();
+                    _queuedEvents.TryDequeue(out _);
                 }
                 _queuedEvents.Enqueue(incomingEvent);
                 return null;
@@ -54,9 +54,12 @@ private void RunningUpdate(System state)
 
         private void ReplayEvents()
         {
-            while (_queuedEvents.Count != 0)
+            while (!_queuedEvents.IsEmpty)
             {
-                analytics.Process(_queuedEvents.Dequeue());
+                if (_queuedEvents.TryDequeue(out var e))
+                {
+                    analytics.Process(e);
+                }
             }
         }
     }

Samples/ConsoleSample/ConsoleSample.csproj

@@ -0,0 +1,12 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+    <PropertyGroup>
+        <OutputType>Exe</OutputType>
+        <TargetFramework>net5.0</TargetFramework>
+    </PropertyGroup>
+
+    <ItemGroup>
+      <ProjectReference Include="..\..\Analytics-CSharp\Analytics-CSharp.csproj" />
+    </ItemGroup>
+
+</Project>

Samples/ConsoleSample/Program.cs

@@ -0,0 +1,28 @@
+// See https://aka.ms/new-console-template for more information
+
+using System;
+using System.Threading;
+using Segment.Analytics;
+using Segment.Concurrent;
+
+
+var configuration = new Configuration("YOUR WRITE KEY",
+    persistentDataPath: "temp",
+    flushAt: 1,
+    flushInterval: 10,
+    exceptionHandler: new ErrorHandler());
+var analytics = new Analytics(configuration);
+
+analytics.Identify("foo");
+analytics.Track("track right after identify");
+
+Console.ReadLine();
+
+
+class ErrorHandler : ICoroutineExceptionHandler
+{
+    public void OnExceptionThrown(Exception e)
+    {
+        Console.WriteLine(e.StackTrace);
+    }
+}