Getting rid of UB in CHAResolver

Author: fabianbs

include/phasar/PhasarLLVM/ControlFlow/Resolver/CHAResolver.h

@@ -32,7 +32,9 @@ class CHAResolver : public Resolver {
   CHAResolver(const LLVMProjectIRDB *IRDB, const LLVMVFTableProvider *VTP,
               const LLVMTypeHierarchy *TH);
 
-  ~CHAResolver() override = default;
+  // Deleting an incomplete type (LLVMTypeHierarchy) is UB, so instantiate the
+  // dtor in CHAResolver.cpp
+  ~CHAResolver() override;
 
   FunctionSetTy resolveVirtualCall(const llvm::CallBase *CallSite) override;
 

lib/PhasarLLVM/ControlFlow/Resolver/CHAResolver.cpp

@@ -40,6 +40,8 @@ CHAResolver::CHAResolver(const LLVMProjectIRDB *IRDB,
   }
 }
 
+CHAResolver::~CHAResolver() = default;
+
 auto CHAResolver::resolveVirtualCall(const llvm::CallBase *CallSite)
     -> FunctionSetTy {
   PHASAR_LOG_LEVEL(DEBUG, "Call virtual function: ");