Enforce rss domain names

Author: acockburn

appdaemon/rundash.py

@@ -107,6 +107,14 @@ def __init__(self, ad, loop, logger, access, **config):
         self.rss_feeds = None
         self._process_arg("rss_feeds", config)
 
+        if "rss_feeds" in config:
+            self.rss_feeds = []
+            for feed in config["rss_feeds"]:
+                if feed["target"].count('.') != 1:
+                    self.log("WARNING", "Invalid RSS feed target: {}".format(feed["target"]))
+                else:
+                    self.rss_feeds.append(feed)
+
         self.rss_update = None
         self._process_arg("rss_update", config)
 

docs/DASHBOARD_CREATION.rst

@@ -978,7 +978,7 @@ Note that the actual feeds are configured in appdaemon.yaml as follows:
 -  ``feed_url`` - fully qualified path to rss feed, e.g.
    ``http://rss.cnn.com/rss/cnn_topstories.rss``
 -  ``target name`` - the entity of the target RSS widget in the
-   dashboard definition file
+   dashboard definition file. This must be an arbitary name prepended by ``rss.`` - e.g. ``rss.cnn_news``
 -  ``feed_refresh_interval`` - how often AppDaemon will refresh the RSS
    feeds
 
@@ -992,7 +992,7 @@ Mandatory Arguments:
 ^^^^^^^^^^^^^^^^^^^^
 
 -  ``entity`` - the name of the configured feed - this must match the
-   ``target_name`` configured in the AppDaemon configuration
+   ``target_name`` full target name configured in the AppDaemon configuration e.g. `rss.cnn_news`
 -  ``interval`` - the period between display of different items within
    the feed
 

docs/HISTORY.rst

@@ -11,10 +11,11 @@ Change Log
 **Fixes**
 
 - Fixed incorrect service call in ``set_value()``
+- Enforce domain name in rss feed target
 
 **Breaking Changes**
 
-None
+- RSS target names must now consist of a domain as well as the target name, e.g. ``rss.cnn_news``
 
 3.0.1
 ------------------