Use URL.canParse

Author: razor-x

src/lib/seam/connect/seam-http-request.ts

@@ -130,15 +130,16 @@ export class SeamHttpRequest<
 }
 
 const getUrlPrefix = (input: string): string => {
-  try {
+  if (URL.canParse(input)) {
     const url = new URL(input).toString()
     if (url.endsWith('/')) return url.slice(0, -1)
     return url
-  } catch (err: unknown) {
-    if (globalThis.location != null) {
-      const pathname = input.startsWith('/') ? input : `/${input}`
-      return new URL(`${globalThis.location.origin}${pathname}`).toString()
-    }
-    throw err
   }
+  if (globalThis.location != null) {
+    const pathname = input.startsWith('/') ? input : `/${input}`
+    return new URL(`${globalThis.location.origin}${pathname}`).toString()
+  }
+  throw new Error(
+    `Cannot resolve origin from ${input} in a non-browser environment`,
+  )
 }

test/seam/connect/seam-http-request.test.ts

@@ -143,7 +143,7 @@ test('SeamHttpRequest: url throws if unable to resolve origin', async (t) => {
 
   const request = seam.devices.get({ device_id: 'abc123' })
 
-  t.throws(() => request.url, { code: 'ERR_INVALID_URL' })
+  t.throws(() => request.url, { message: /Cannot resolve origin/ })
 })
 
 const toPlainUrlObject = (url: URL): Omit<URL, 'searchParams' | 'toJSON'> => {