Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action attempts to blueprint #148

Open
1 of 2 tasks
razor-x opened this issue Jan 10, 2025 · 4 comments · May be fixed by #153
Open
1 of 2 tasks

Add action attempts to blueprint #148

razor-x opened this issue Jan 10, 2025 · 4 comments · May be fixed by #153
Assignees

Comments

@razor-x
Copy link
Collaborator

razor-x commented Jan 10, 2025

  • Represent in blueprint similar to events
  • Connect endpoint response to action attempt type
@razor-x
Copy link
Collaborator Author

razor-x commented Jan 10, 2025

@andrii-balitskyi We need to find a way for the endpoint response in blueprint to indicate what action attempt type it returns. We could annotate it in the yaml on the endpoint, but is there a way we can handle this automatically from the route spec?

@andrii-balitskyi
Copy link
Contributor

andrii-balitskyi commented Jan 13, 2025

@razor-x I can't think of another way to compute the action attempt type from the endpoint's route spec other than annotating it in the route spec's description front matter.

@razor-x razor-x added the blueprint label Jan 14, 2025 — with Linear
@razor-x razor-x changed the title Add action attempts Add action attempts Jan 14, 2025
@andrii-balitskyi
Copy link
Contributor

@razor-x Should we express this endpoint relation using something like responseActionAttemptType in endpoint.response?

@razor-x
Copy link
Collaborator Author

razor-x commented Jan 16, 2025

@razor-x Should we express this endpoint relation using something like responseActionAttemptType in endpoint.response?

Yes, but just actionAttemptType should be fine

@razor-x razor-x changed the title Add action attempts Add action attempts to blueprint Jan 22, 2025
@andrii-balitskyi andrii-balitskyi linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants