Skip to content

Commit e1c766e

Browse files
pyokaganEclipse-Dominator
authored andcommitted
Add tests for #equals(Object) implementations
1 parent 9ec3254 commit e1c766e

File tree

5 files changed

+104
-0
lines changed

5 files changed

+104
-0
lines changed

Diff for: src/test/java/seedu/address/AppParametersTest.java

+24
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package seedu.address;
22

33
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static org.junit.jupiter.api.Assertions.assertFalse;
5+
import static org.junit.jupiter.api.Assertions.assertTrue;
46

57
import java.nio.file.Paths;
68
import java.util.Collections;
@@ -44,6 +46,28 @@ public void toStringMethod() {
4446
assertEquals(expected, appParameters.toString());
4547
}
4648

49+
@Test
50+
public void equals() {
51+
AppParameters appParameters = new AppParameters();
52+
53+
// same values -> returns true
54+
assertTrue(appParameters.equals(new AppParameters()));
55+
56+
// same object -> returns true
57+
assertTrue(appParameters.equals(appParameters));
58+
59+
// null -> returns false
60+
assertFalse(appParameters.equals(null));
61+
62+
// different types -> returns false
63+
assertFalse(appParameters.equals(5.0f));
64+
65+
// different config path -> returns false
66+
AppParameters otherAppParameters = new AppParameters();
67+
otherAppParameters.setConfigPath(Paths.get("configPath"));
68+
assertFalse(appParameters.equals(otherAppParameters));
69+
}
70+
4771
private static class ParametersStub extends Application.Parameters {
4872
private Map<String, String> namedParameters = new HashMap<>();
4973

Diff for: src/test/java/seedu/address/model/person/AddressTest.java

+20
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,24 @@ public void isValidAddress() {
3333
assertTrue(Address.isValidAddress("-")); // one character
3434
assertTrue(Address.isValidAddress("Leng Inc; 1234 Market St; San Francisco CA 2349879; USA")); // long address
3535
}
36+
37+
@Test
38+
public void equals() {
39+
Address address = new Address("Valid Address");
40+
41+
// same values -> returns true
42+
assertTrue(address.equals(new Address("Valid Address")));
43+
44+
// same object -> returns true
45+
assertTrue(address.equals(address));
46+
47+
// null -> returns false
48+
assertFalse(address.equals(null));
49+
50+
// different types -> returns false
51+
assertFalse(address.equals(5.0f));
52+
53+
// different values -> returns false
54+
assertFalse(address.equals(new Address("Other Valid Address")));
55+
}
3656
}

Diff for: src/test/java/seedu/address/model/person/EmailTest.java

+20
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,24 @@ public void isValidEmail() {
6565
assertTrue(Email.isValidEmail("[email protected]")); // long local part
6666
assertTrue(Email.isValidEmail("[email protected]")); // more than one period in domain
6767
}
68+
69+
@Test
70+
public void equals() {
71+
Email email = new Email("valid@email");
72+
73+
// same values -> returns true
74+
assertTrue(email.equals(new Email("valid@email")));
75+
76+
// same object -> returns true
77+
assertTrue(email.equals(email));
78+
79+
// null -> returns false
80+
assertFalse(email.equals(null));
81+
82+
// different types -> returns false
83+
assertFalse(email.equals(5.0f));
84+
85+
// different values -> returns false
86+
assertFalse(email.equals(new Email("other.valid@email")));
87+
}
6888
}

Diff for: src/test/java/seedu/address/model/person/NameTest.java

+20
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,24 @@ public void isValidName() {
3737
assertTrue(Name.isValidName("Capital Tan")); // with capital letters
3838
assertTrue(Name.isValidName("David Roger Jackson Ray Jr 2nd")); // long names
3939
}
40+
41+
@Test
42+
public void equals() {
43+
Name name = new Name("Valid Name");
44+
45+
// same values -> returns true
46+
assertTrue(name.equals(new Name("Valid Name")));
47+
48+
// same object -> returns true
49+
assertTrue(name.equals(name));
50+
51+
// null -> returns false
52+
assertFalse(name.equals(null));
53+
54+
// different types -> returns false
55+
assertFalse(name.equals(5.0f));
56+
57+
// different values -> returns false
58+
assertFalse(name.equals(new Name("Other Valid Name")));
59+
}
4060
}

Diff for: src/test/java/seedu/address/model/person/PhoneTest.java

+20
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,24 @@ public void isValidPhone() {
3737
assertTrue(Phone.isValidPhone("93121534"));
3838
assertTrue(Phone.isValidPhone("124293842033123")); // long phone numbers
3939
}
40+
41+
@Test
42+
public void equals() {
43+
Phone phone = new Phone("999");
44+
45+
// same values -> returns true
46+
assertTrue(phone.equals(new Phone("999")));
47+
48+
// same object -> returns true
49+
assertTrue(phone.equals(phone));
50+
51+
// null -> returns false
52+
assertFalse(phone.equals(null));
53+
54+
// different types -> returns false
55+
assertFalse(phone.equals(5.0f));
56+
57+
// different values -> returns false
58+
assertFalse(phone.equals(new Phone("995")));
59+
}
4060
}

0 commit comments

Comments
 (0)