Skip to content

Conversation

@QuerthDP
Copy link
Member

@QuerthDP QuerthDP commented Dec 8, 2025

When running Validator with subset of tests, the total number of tests in statistics was incorrect.
It represented all tests in a test file, not only those selected.

This fix changes the total number of tests to only the tests being run. The pass results should show total = launched = ok.

Fixes: VECTOR-392

@github-actions github-actions bot added P4 and removed P4 labels Dec 8, 2025
@QuerthDP
Copy link
Member Author

QuerthDP commented Dec 8, 2025

Cargo Deny failed although I'm not sure what would be the fix for it. Seems like it fails on master as well.
@ewienik could you look at that?

@ewienik
Copy link
Collaborator

ewienik commented Dec 8, 2025

Cargo Deny failed although I'm not sure what would be the fix for it. Seems like it fails on master as well. @ewienik could you look at that?

It seems that rustls-pemfile is unmaintained now. We need to switch to rustls-pki-types

error[unmaintained]: rustls-pemfile is unmaintained
    ┌─ /home/runner/work/vector-store/vector-store/Cargo.lock:255:1
    │
255 │ rustls-pemfile 2.2.0 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
    │
    ├ ID: RUSTSEC-2025-0134
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0134
    ├ The rustls-pemfile crate is no longer maintained. The repository has been archived since August
      2025, and users are encouraged to depend directly on the underlying PEM parsing code included
      in rustls-pki-types since 1.9.0. The latest version of rustls-pemfile is in fact a thin wrapper
      around the same code used in rustls-pki-types, so migrating should be straightforward.
      
      The new API is represented by the [`PemObject`][PemObject] trait, which provides methods for
      reading a single or multiple PEM objects from a file or byte slice.

@ewienik
Copy link
Collaborator

ewienik commented Dec 8, 2025

It seems that rustls-pemfile is unmaintained now. We need to switch to rustls-pki-types

I've just created VECTOR-396

@QuerthDP QuerthDP enabled auto-merge December 8, 2025 11:23
When running Validator with subset of tests, the `total`
number of tests in statistics was incorrect.
It represented all tests in a test file, not only those selected.

This fix changes the `total` number of tests to only the tests
being run. The pass results should show `total` = `launched` = `ok`.

Fixes: VECTOR-392
@QuerthDP
Copy link
Member Author

QuerthDP commented Dec 8, 2025

Changelog:

  • rebased on master

@QuerthDP QuerthDP added this pull request to the merge queue Dec 8, 2025
Merged via the queue into scylladb:master with commit 898a436 Dec 8, 2025
5 checks passed
@QuerthDP QuerthDP deleted the fix-total-tests branch December 8, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants