Skip to content

Fix populate() workaround in tablet code #288

Open
@avelanarius

Description

@avelanarius

The current implementation has the following workaround:

dfccfff#diff-96bfc85b77a504cf9f31ccf706cecb133eb418bc3e7a125e28bf5fa887d8c6b9R1789-R1796

    self.load_balancing_policy._tablets_routing_v1 = self.control_connection._tablets_routing_v1
    child_policy = self.load_balancing_policy.child_policy if hasattr(self.load_balancing_policy, 'child_policy') else None
    while child_policy is not None:
        if hasattr(child_policy, '_tablet_routing_v1'):
            child_policy._tablet_routing_v1 = self.control_connection._tablets_routing_v1
        child_policy = child_policy.child_policy if hasattr(child_policy, 'child_policy') else None

This used to be a populate() call, but this sometimes failed some tests in CI (not reproducible locally). We should investigate the reason why it did so.

Creating this issue so we won't forget about this problem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions