forked from datastax/python-driver
-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
enhancementNew feature or requestNew feature or requestupstream-issueIssue is not specific to our fork and Scylla and should be also fixed in the upstreamIssue is not specific to our fork and Scylla and should be also fixed in the upstream
Description
In the cqlengine, there is BatchQuery
class -
python-driver/cassandra/cqlengine/query.py
Line 136 in cd1f5ed
class BatchQuery(object): |
For some reason, in it's execute method it serializes whole batch to the string - instead of using
BatchStatement
python-driver/cassandra/query.py
Line 710 in cd1f5ed
class BatchStatement(Statement): |
This is 1. bad in terms of performance 2. causes other issues - e.g. here
python-driver/cassandra/cluster.py
Line 5366 in cd1f5ed
is_batch_statement = isinstance(self.response_future.query, BatchStatement) |
BatchQuery
obviously won't.
Unless there is some fundamental reason for this behavior, we should fix it.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestupstream-issueIssue is not specific to our fork and Scylla and should be also fixed in the upstreamIssue is not specific to our fork and Scylla and should be also fixed in the upstream