Skip to content

Commit cdda1dc

Browse files
authoredJun 1, 2024
feat(contracts): change MAX_COMMIT_SCALAR and MAX_BLOB_SCALAR to 1e18 (#1354)
1 parent 159df24 commit cdda1dc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎src/L2/predeploys/L1GasPriceOracle.sol

+4-4
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,16 @@ contract L1GasPriceOracle is OwnableBase, IL1GasPriceOracle {
5959
/// ```
6060
/// commit_scalar = commit_gas_per_tx * fluctuation_multiplier * 1e9
6161
/// ```
62-
/// So, the value should not exceed 10^18 * 1e9 normally.
63-
uint256 private constant MAX_COMMIT_SCALAR = 10 ** 18 * PRECISION;
62+
/// So, the value should not exceed 10^9 * 1e9 normally.
63+
uint256 private constant MAX_COMMIT_SCALAR = 10 ** 9 * PRECISION;
6464

6565
/// @dev The maximum possible l1 blob fee scalar after Curie.
6666
/// We derive the blob scalar by
6767
/// ```
6868
/// blob_scalar = fluctuation_multiplier / compression_ratio / blob_util_ratio * 1e9
6969
/// ```
70-
/// So, the value should not exceed 10^18 * 1e9 normally.
71-
uint256 private constant MAX_BLOB_SCALAR = 10 ** 18 * PRECISION;
70+
/// So, the value should not exceed 10^9 * 1e9 normally.
71+
uint256 private constant MAX_BLOB_SCALAR = 10 ** 9 * PRECISION;
7272

7373
/*************
7474
* Variables *

‎src/test/L1GasPriceOracle.t.sol

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ contract L1GasPriceOracleTest is DSTestPlus {
1111
uint256 private constant PRECISION = 1e9;
1212
uint256 private constant MAX_OVERHEAD = 30000000 / 16;
1313
uint256 private constant MAX_SCALAR = 1000 * PRECISION;
14-
uint256 private constant MAX_COMMIT_SCALAR = 10 ** 18 * PRECISION;
15-
uint256 private constant MAX_BLOB_SCALAR = 10 ** 18 * PRECISION;
14+
uint256 private constant MAX_COMMIT_SCALAR = 10 ** 9 * PRECISION;
15+
uint256 private constant MAX_BLOB_SCALAR = 10 ** 9 * PRECISION;
1616

1717
L1GasPriceOracle private oracle;
1818
Whitelist private whitelist;

0 commit comments

Comments
 (0)
Please sign in to comment.