Skip to content

feat(network): enable add extra-protocol to network component by ScrollNetworkBuilder #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: scroll
Choose a base branch
from

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jul 19, 2025

This PR aims to fix the issue.

the root cause is that the node will try handshake will peers as soon as the network component launched, but it will take time for network to process add scroll_wire sub-protocol event.

So add feature here that we can add extra-protocol before we launch the network component.

@yiweichi yiweichi changed the title fix(network): extra protocol scroll-wire initialized too late feat(network): enable add extra-protocol to network component by ScrollNetworkBuilder Jul 19, 2025
Copy link

codspeed-hq bot commented Jul 19, 2025

CodSpeed Performance Report

Merging #282 will not alter performance

Comparing fix-extra-protocol-scroll-wire-initialization (674e0e1) with scroll (aad1706)

Summary

✅ 77 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant