Change name of options class for visibility (#19)

Author: scottoffen

README.md

@@ -422,16 +422,17 @@ public static class FluentHttpClientExtensions
 }
 ```
 
-## Default Json Serialization Options
+## Default JsonSerializerOptions
 
 Unless explicitly passed in the method call for serialization or deserialization of JSON, the following default `JsonSerializerOptions` will be used:
 
 ```csharp
 new JsonSerializerOptions
 {
     PropertyNameCaseInsensitive = true,
+    NumberHandling = JsonNumberHandling.AllowReadingFromString,
     DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
 };
 ```
 
-This default can be overridden or modified via the `FluentHttpClient.DefaultJsonSerializerOptions` property.
+This default can be overridden or modified via the `FluentHttpClientOptions.DefaultJsonSerializerOptions` property.

src/FluentHttpClient.Tests/QueryParamsTests.cs

@@ -7,7 +7,7 @@ public class QueryParamsTests
     [Fact]
     public void DoesNotRemoveEmptyValues()
     {
-        FluentHttpClient.RemoveEmptyQueryParameters = false;
+        FluentHttpClientOptions.RemoveEmptyQueryParameters = false;
 
         var expected = "?name=bob&age=&color=blue";
 
@@ -25,7 +25,7 @@ public void DoesNotRemoveEmptyValues()
     [Fact]
     public void RemovesEmptyValues()
     {
-        FluentHttpClient.RemoveEmptyQueryParameters = true;
+        FluentHttpClientOptions.RemoveEmptyQueryParameters = true;
 
         var expected = "?name=bob&color=blue";
 

src/FluentHttpClient/FluentHttpClient.csproj

@@ -15,7 +15,7 @@
     <PackageTags>fluent httpclient rest http api web client</PackageTags>
     <AssemblyVersion>$(Version)</AssemblyVersion>
     <FileVersion>$(Version)</FileVersion>
-    <Version>3.0.4</Version>
+    <Version>3.0.5</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>

src/FluentHttpClient/FluentHttpClient.cs src/FluentHttpClient/FluentHttpClientOptions.cs

@@ -3,11 +3,15 @@
 
 namespace FluentHttpClient;
 
-public static class FluentHttpClient
+public static class FluentHttpClientOptions
 {
+    /// <summary>
+    /// Default JsonSerializerOptions that will be use when serializing and deserializing if none are provided.
+    /// </summary>
     public static JsonSerializerOptions DefaultJsonSerializerOptions { get; set; } = new JsonSerializerOptions
     {
         PropertyNameCaseInsensitive = true,
+        NumberHandling = JsonNumberHandling.AllowReadingFromString,
         DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
     };
 

src/FluentHttpClient/FluentJsonDeserialization.cs

@@ -6,7 +6,7 @@ public static class FluentJsonDeserialization
 {
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<Stream> result)
     {
-        return await result.DeserializeJsonAsync<T>(FluentHttpClient.DefaultJsonSerializerOptions);
+        return await result.DeserializeJsonAsync<T>(FluentHttpClientOptions.DefaultJsonSerializerOptions);
     }
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<Stream> result, JsonSerializerOptions options)
@@ -16,7 +16,7 @@ public static class FluentJsonDeserialization
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<String> result)
     {
-        return await result.DeserializeJsonAsync<T>(FluentHttpClient.DefaultJsonSerializerOptions);
+        return await result.DeserializeJsonAsync<T>(FluentHttpClientOptions.DefaultJsonSerializerOptions);
     }
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<string> result, JsonSerializerOptions options)
@@ -26,7 +26,7 @@ public static class FluentJsonDeserialization
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<HttpResponseMessage> result)
     {
-        return await result.DeserializeJsonAsync<T>(FluentHttpClient.DefaultJsonSerializerOptions);
+        return await result.DeserializeJsonAsync<T>(FluentHttpClientOptions.DefaultJsonSerializerOptions);
     }
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<HttpResponseMessage> taskResponse, JsonSerializerOptions options)
@@ -37,7 +37,7 @@ public static class FluentJsonDeserialization
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<HttpResponseMessage> result, Func<HttpResponseMessage, T> defaultAction)
     {
-        return await result.DeserializeJsonAsync<T>(defaultAction, FluentHttpClient.DefaultJsonSerializerOptions);
+        return await result.DeserializeJsonAsync<T>(defaultAction, FluentHttpClientOptions.DefaultJsonSerializerOptions);
     }
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<HttpResponseMessage> taskResponse, Func<HttpResponseMessage, T> defaultAction, JsonSerializerOptions options)
@@ -50,7 +50,7 @@ public static class FluentJsonDeserialization
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<HttpResponseMessage> result, Func<HttpResponseMessage, Task<T>> defaultAction)
     {
-        return await result.DeserializeJsonAsync<T>(defaultAction, FluentHttpClient.DefaultJsonSerializerOptions);
+        return await result.DeserializeJsonAsync<T>(defaultAction, FluentHttpClientOptions.DefaultJsonSerializerOptions);
     }
 
     public static async Task<T?> DeserializeJsonAsync<T>(this Task<HttpResponseMessage> taskResponse, Func<HttpResponseMessage, Task<T>> defaultAction, JsonSerializerOptions options)

src/FluentHttpClient/HttpRequestBuilderExtensions.cs

@@ -155,7 +155,7 @@ public static partial class HttpRequestBuilderExtensions
 {
     public static HttpRequestBuilder WithJsonContent(this HttpRequestBuilder builder, object content)
     {
-        return builder.WithJsonContent(content, FluentHttpClient.DefaultJsonSerializerOptions);
+        return builder.WithJsonContent(content, FluentHttpClientOptions.DefaultJsonSerializerOptions);
     }
 
     public static HttpRequestBuilder WithJsonContent(this HttpRequestBuilder builder, object content, JsonSerializerOptions options)

src/FluentHttpClient/QueryParams.cs

@@ -15,7 +15,7 @@ public override string ToString()
             from key in AllKeys
             let value = Get(key)
             where (
-                !FluentHttpClient.RemoveEmptyQueryParameters
+                !FluentHttpClientOptions.RemoveEmptyQueryParameters
                 || !string.IsNullOrWhiteSpace(value)
             )
             select $"{Uri.EscapeDataString(key)}={Uri.EscapeDataString(value)}"