From 76c2bc1e16286ac2bc3186a066e1d821e3fc9bb5 Mon Sep 17 00:00:00 2001
From: Scott Bilas <scottbilas@gmail.com>
Date: Sun, 1 Dec 2024 16:45:47 +0000
Subject: [PATCH] New BannedSymbols feature

---
 src/Core/BannedSymbols.txt     |  1 +
 src/Core/Core.csproj           |  2 +-
 src/Terminal/BannedSymbols.txt |  6 ++++++
 src/Terminal/Terminal.csproj   |  3 ++-
 targets/Library.targets        | 10 ++++++++++
 5 files changed, 20 insertions(+), 2 deletions(-)
 create mode 100644 src/Core/BannedSymbols.txt
 create mode 100644 src/Terminal/BannedSymbols.txt

diff --git a/src/Core/BannedSymbols.txt b/src/Core/BannedSymbols.txt
new file mode 100644
index 0000000..501ca52
--- /dev/null
+++ b/src/Core/BannedSymbols.txt
@@ -0,0 +1 @@
+// https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md
diff --git a/src/Core/Core.csproj b/src/Core/Core.csproj
index a1ab9f3..a56c69c 100644
--- a/src/Core/Core.csproj
+++ b/src/Core/Core.csproj
@@ -1,5 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup><OkFeatures>T4;NetMulti</OkFeatures></PropertyGroup>
+  <PropertyGroup><OkFeatures>T4;NetMulti;BannedSymbols</OkFeatures></PropertyGroup>
   <Import Project="$(OkTargetsRoot)Library.targets" />
 
   <PropertyGroup>
diff --git a/src/Terminal/BannedSymbols.txt b/src/Terminal/BannedSymbols.txt
new file mode 100644
index 0000000..9879947
--- /dev/null
+++ b/src/Terminal/BannedSymbols.txt
@@ -0,0 +1,6 @@
+// https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md
+
+T:System.IO.Path;Use NiceIO NPath instead
+T:System.IO.Directory;Use NiceIO NPath instead
+M:System.Text.StringBuilder.AppendLine;Use AppendLf instead
+M:System.Text.StringBuilder.AppendLine(System.String);Use AppendLf instead
diff --git a/src/Terminal/Terminal.csproj b/src/Terminal/Terminal.csproj
index eb60490..a2685c9 100644
--- a/src/Terminal/Terminal.csproj
+++ b/src/Terminal/Terminal.csproj
@@ -1,5 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup><OkFeatures>Core;NetMulti</OkFeatures></PropertyGroup>
+  <PropertyGroup><OkFeatures>Core;NetMulti;BannedSymbols</OkFeatures></PropertyGroup>
   <Import Project="$(OkTargetsRoot)Library.targets" />
 
   <PropertyGroup>
@@ -25,6 +25,7 @@
     <None Include="../../LICENSE.md" Pack="true" PackagePath="/" />
   </ItemGroup>
 
+  <!-- dependencies -->
   <ItemGroup>
     <PackageReference Include="docopt.net" />
     <PackageReference Include="Spectre.Console" />
diff --git a/targets/Library.targets b/targets/Library.targets
index e4c7bd8..5fd0c50 100644
--- a/targets/Library.targets
+++ b/targets/Library.targets
@@ -91,6 +91,16 @@
     <NoWarn>$(NoWarn);RS0030</NoWarn>
   </PropertyGroup>
 
+  <!-- Feature: BannedSymbols -->
+
+  <ItemGroup Condition=" $(OkFeatures.Contains(';BannedSymbols;')) ">
+    <PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+    <!-- put this in the csproj also: <AdditionalFiles Include="BannedSymbols.txt"/> -->
+  </ItemGroup>
+
   <!-- Feature: T4 -->
   <!-- TEMPORARILY DISABLED - T4.Build does not support .NET 8 SDK, gets an error from a missing assembly.
        just go with manual Rider-based T4 for now. -->