Skip to content

Commit d6920c5

Browse files
committed
refactor
unnecessary getTestRepoUrl() is removed documentation updated
1 parent c0b4438 commit d6920c5

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

README.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,20 @@ Features:
1313
- File content getting and setting
1414
- File create and remove
1515

16+
Use cases
17+
- VCS server hooks
18+
- Build machines
19+
- checking in\out, tagging
20+
- Software project management systems
21+
- Create own branches from GUI, browse commits, product versions management, etc
22+
- Product release automation
23+
- automatic merging, forking, tagging, version bumping, etc
24+
- Example: [scm4j-releaser](https://github.com/scm4j/scm4j-releaser)
25+
26+
1627
# Terms
1728
- Workspace Home
1829
- Local home folder of all folders used by vcs-related operations. See [scm4j-vcs-api](https://github.com/scm4j/scm4j-vcs-api) for details
19-
- Repository Workspace
20-
- Local folder for LWC folders related to Repository of one type. See [scm4j-vcs-api](https://github.com/scm4j/scm4j-vcs-api) for details
2130
- Locked Working Copy, LWC
2231
- Local folder where vcs-related operations are executed. Provides thread- and process-safe repository of working folders. See [scm4j-vcs-api](https://github.com/scm4j/scm4j-vcs-api) for details
2332
- Test Repository
@@ -60,7 +69,7 @@ Features:
6069
- Or run `gradle test`
6170

6271
# Limitations
63-
- According to IVCS description `IVCS.getBranches()` should return list of user-created branches. But a branch and a dir are the same for SVN. So `SVNVCS.getBranches()` returns set of first level folders of "Branches/" branch and "Trunk" branch. I.e.:
72+
- According to IVCS description `IVCS.getBranches()` should return list of user-created branches. But a branch and a dir are the same for SVN. So `SVNVCS.getBranches()` returns set of first-level folders of "Branches/" branch and "Trunk" branch. I.e.:
6473
- Assume we have following directory structure:
6574
- Branches/Br1/Folder/file.txt
6675
- Branches/Br2/Folder/file.txt

src/main/java/org/scm4j/vcs/svn/SVNVCS.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ public String getVCSTypeString() {
503503

504504
@Override
505505
public VCSCommit removeFile(String branchName, String filePath, String commitMessage) {
506-
try (IVCSLockedWorkingCopy wc = repo.getVCSLockedWorkingCopy()) {
506+
try {
507507
SVNCommitInfo res = clientManager
508508
.getCommitClient()
509509
.doDelete(new SVNURL[] {getBranchUrl(branchName).appendPath(filePath, true)}, commitMessage);

src/test/java/org/scm4j/vcs/svn/SVNVCSTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,6 @@ public String getVCSTypeString() {
6464
return "svn";
6565
}
6666

67-
@Override
68-
protected String getTestRepoUrl() {
69-
return "file:///" + localVCSWorkspace.getHomeFolder().getPath().replace("\\", "/") + "/";
70-
}
71-
7267
@Override
7368
protected IVCS getVCS(IVCSRepositoryWorkspace mockedVCSRepo) {
7469
// nulls as user and pwd because we using file repository, not server

0 commit comments

Comments
 (0)