cmd/scion-pki: improve CLI UX #4803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
commented
Jul 9, 2025
|
|
||
| // ReadFileOrStdin reads the content of a file or stdin if the path is "-". | ||
| // It returns the content as a byte slice. | ||
| func ReadFileOrStdin(path string) ([]byte, error) { |
Contributor
Author
There was a problem hiding this comment.
Open for suggestions if there is a more suitable place to put this.
katyatitkova
approved these changes
Jul 9, 2025
The `scion-pki` CLI commands now support reading from stdin when the file path is set to `-`, where appropriate. This allows the user to pipe data directly into the command without the need to create temporary files. Furthermore, the `scion-pki trc extract certificates` command has two additional filtering options: `--type` and `--subject.isd-as`, allowing the user to filter the extracted certificates.
oncilla
force-pushed
the
scion-pki-extract
branch
from
c732967 to
4c0fc53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scion-pkiCLI commands now support reading from stdin when the file path is set to-, where appropriate. This allows the user to pipe data directly into the command without the need to create temporary files.Furthermore, the
scion-pki trc extract certificatescommand has two additional filtering options:--typeand--subject.isd-as, allowing the user to filter the extracted certificates.