You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The NodeTraversor class is currently internal, which makes it unusable outside the module. Additionally, the traverse(_:) method is marked as open, which has no effect unless the class itself is open.
Steps to reproduce
Try to subclass NodeTraversor in a project that imports SwiftSoup.
Notice that the class is inaccessible.
Expected behavior
The NodeTraversor class should be open so that it can be used and subclassed outside the module.
Proposed solution
Change:
internalclass NodeTraversor
With:
openclass NodeTraversor
This will align with the existing open func traverse(_:) declaration and allow proper subclassing.
The text was updated successfully, but these errors were encountered:
Describe the issue
The
NodeTraversor
class is currentlyinternal
, which makes it unusable outside the module. Additionally, thetraverse(_:)
method is marked asopen
, which has no effect unless the class itself isopen
.Steps to reproduce
NodeTraversor
in a project that imports SwiftSoup.Expected behavior
The
NodeTraversor
class should beopen
so that it can be used and subclassed outside the module.Proposed solution
Change:
With:
This will align with the existing
open func traverse(_:)
declaration and allow proper subclassing.The text was updated successfully, but these errors were encountered: